| Message ID | 20250327144439.2463509-1-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7220e8f4d4eec0b2f682eef45e2d36c092738413 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: lapbether: use netdev_lockdep_set_classes() helper | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 27 Mar 2025 14:44:39 +0000 you wrote: > drivers/net/wan/lapbether.c uses stacked devices. > Like similar drivers, it must use netdev_lockdep_set_classes() > to avoid LOCKDEP splats. > > This is similar to commit 9bfc9d65a1dc ("hamradio: > use netdev_lockdep_set_classes() helper") > > [...] Here is the summary with links: - [net] net: lapbether: use netdev_lockdep_set_classes() helper https://git.kernel.org/netdev/net/c/7220e8f4d4ee You are awesome, thank you!
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c index 56326f38fe8a30f45e88cdce7efd43e18041e52a..995a7207bdf8719899bbbe58b84707eb4c2e9c1d 100644 --- a/drivers/net/wan/lapbether.c +++ b/drivers/net/wan/lapbether.c @@ -39,6 +39,7 @@ #include <linux/lapb.h> #include <linux/init.h> +#include <net/netdev_lock.h> #include <net/x25device.h> static const u8 bcast_addr[6] = { 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF }; @@ -366,6 +367,7 @@ static const struct net_device_ops lapbeth_netdev_ops = { static void lapbeth_setup(struct net_device *dev) { + netdev_lockdep_set_classes(dev); dev->netdev_ops = &lapbeth_netdev_ops; dev->needs_free_netdev = true; dev->type = ARPHRD_X25;
drivers/net/wan/lapbether.c uses stacked devices. Like similar drivers, it must use netdev_lockdep_set_classes() to avoid LOCKDEP splats. This is similar to commit 9bfc9d65a1dc ("hamradio: use netdev_lockdep_set_classes() helper") Fixes: 7e4d784f5810 ("net: hold netdev instance lock during rtnetlink operations") Reported-by: syzbot+377b71db585c9c705f8e@syzkaller.appspotmail.com Closes: https://lore.kernel.org/lkml/67cd611c.050a0220.14db68.0073.GAE@google.com/T/#u Signed-off-by: Eric Dumazet <edumazet@google.com> Acked-by: Stanislav Fomichev <sdf@fomichev.me> --- drivers/net/wan/lapbether.c | 2 ++ 1 file changed, 2 insertions(+)