@@ -775,10 +775,12 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
if (what)
close_json_object();
} else {
+ uint64_t zero64 = 0;
+
size_columns(cols, ARRAY_SIZE(cols),
s->rx_bytes, s->rx_packets, s->rx_errors,
s->rx_dropped, s->rx_missed_errors,
- s->multicast, s->rx_compressed);
+ s->multicast, s->rx_compressed, zero64);
if (show_stats > 1)
size_columns(cols, ARRAY_SIZE(cols), 0,
s->rx_length_errors, s->rx_crc_errors,
@@ -788,7 +790,7 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
size_columns(cols, ARRAY_SIZE(cols),
s->tx_bytes, s->tx_packets, s->tx_errors,
s->tx_dropped, s->tx_carrier_errors,
- s->collisions, s->tx_compressed);
+ s->collisions, s->tx_compressed, zero64);
if (show_stats > 1)
size_columns(cols, ARRAY_SIZE(cols), 0, 0,
s->tx_aborted_errors, s->tx_fifo_errors,
@@ -796,7 +798,8 @@ void print_stats64(FILE *fp, struct rtnl_link_stats64 *s,
s->tx_heartbeat_errors,
(uint64_t)(carrier_changes ?
rta_getattr_u32(carrier_changes)
- : 0));
+ : 0),
+ zero64);
/* RX stats */
fprintf(fp, " RX: %*s %*s %*s %*s %*s %*s %*s%s",
The commit cited below added a new column to print_stats64(). However it then updated only one call site, neglecting to update the remaining three. As a result, in those not-updated invocations, size_columns() now accesses a vararg argument that is not being passed, which is undefined behavior. Fixes: cebf67a35d8a ("show rx_otherehost_dropped stat in ip link show") CC: Tariq Toukan <tariqt@nvidia.com> CC: Itay Aveksis <itayav@nvidia.com> Signed-off-by: Petr Machata <petrm@nvidia.com> --- ip/ipaddress.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)