| Message ID | 23d7592c5d77d75cff9b34f15c227f92e911c2ae.1706635101.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc0970d5ac1d1317e212bdf55533935ecb6ae95c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: net: a few pmtu.sh fixes | expand |
On Tue, Jan 30, 2024 at 06:47:18PM +0100, Paolo Abeni wrote: > When running the pmtu.sh via the kselftest infra, accessing > /dev/stdout gives unexpected results: > # dd: failed to open '/dev/stdout': Device or resource busy > # TEST: IPv4, bridged vxlan4: PMTU exceptions [FAIL] > > Let dd use directly the standard output to fix the above: > # TEST: IPv4, bridged vxlan4: PMTU exceptions - nexthop objects [ OK ] > Reviewed-by: Guillaume Nault <gnault@redhat.com>
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh index 31892b366913..3f118e3f1c66 100755 --- a/tools/testing/selftests/net/pmtu.sh +++ b/tools/testing/selftests/net/pmtu.sh @@ -1339,7 +1339,7 @@ test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() { sleep 1 - dd if=/dev/zero of=/dev/stdout status=none bs=1M count=1 | ${target} socat -T 3 -u STDIN $TCPDST,connect-timeout=3 + dd if=/dev/zero status=none bs=1M count=1 | ${target} socat -T 3 -u STDIN $TCPDST,connect-timeout=3 size=$(du -sb $tmpoutfile) size=${size%%/tmp/*}
When running the pmtu.sh via the kselftest infra, accessing /dev/stdout gives unexpected results: # dd: failed to open '/dev/stdout': Device or resource busy # TEST: IPv4, bridged vxlan4: PMTU exceptions [FAIL] Let dd use directly the standard output to fix the above: # TEST: IPv4, bridged vxlan4: PMTU exceptions - nexthop objects [ OK ] Fixes: 136a1b434bbb ("selftests: net: test vxlan pmtu exceptions with tcp") Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- tools/testing/selftests/net/pmtu.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)