| Message ID | 25b34e3bea4da381228953e484e5c699796dafe8.1636315896.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c45231a7668d6b632534f692b10592ea375b55b0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | litex_liteeth: Fix a double free in the remove function | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 7 Nov 2021 21:13:07 +0100 you wrote: > 'netdev' is a managed resource allocated in the probe using > 'devm_alloc_etherdev()'. > It must not be freed explicitly in the remove function. > > Fixes: ee7da21ac4c3 ("net: Add driver for LiteX's LiteETH network interface") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > [...] Here is the summary with links: - litex_liteeth: Fix a double free in the remove function https://git.kernel.org/netdev/net/c/c45231a7668d You are awesome, thank you!
diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c index 3d9385a4989b..24ed6e180c75 100644 --- a/drivers/net/ethernet/litex/litex_liteeth.c +++ b/drivers/net/ethernet/litex/litex_liteeth.c @@ -289,7 +289,6 @@ static int liteeth_remove(struct platform_device *pdev) struct net_device *netdev = platform_get_drvdata(pdev); unregister_netdev(netdev); - free_netdev(netdev); return 0; }
'netdev' is a managed resource allocated in the probe using 'devm_alloc_etherdev()'. It must not be freed explicitly in the remove function. Fixes: ee7da21ac4c3 ("net: Add driver for LiteX's LiteETH network interface") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/litex/litex_liteeth.c | 1 - 1 file changed, 1 deletion(-)