From patchwork Mon Jul 18 08:17:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 12920982 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AD2EC43334 for ; Mon, 18 Jul 2022 08:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233567AbiGRISZ (ORCPT ); Mon, 18 Jul 2022 04:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232796AbiGRISX (ORCPT ); Mon, 18 Jul 2022 04:18:23 -0400 Received: from mail.sberdevices.ru (mail.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C51518E0D; Mon, 18 Jul 2022 01:18:22 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mail.sberdevices.ru (Postfix) with ESMTP id E4C595FD02; Mon, 18 Jul 2022 11:18:20 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1658132300; bh=qE3oICe7EFjo8tBFXaB+54QUv+zuKwoUREtOQS9uPkI=; h=From:To:Subject:Date:Message-ID:Content-Type:MIME-Version; b=UWMKMHr/QTzKS6bP877LWnR1qzAfuH4KhypdiAI33Emzzn//E84vDckRKMy4tprK1 9qhrDYFqmageiypiPv6G716fe1I1e2Wfpt3pp9hn5W4LyPmXzrKymp9DxhGrJrLj6V iFCMfZj2Lv7Q+gllGsjn96pix0wybVQdBBdgYbLPRSeLSh/aZlYp49PW/x946Nqz7X g9PAkctNKp+IHqvVFXfJ5UNuf+pfrmAbWIkhp/K7NFRn6jYvZEK2ePvb99Wz5Lk0Do /tLBuHkx7tz4r93gNcJb0Fu6+pt2XNmwYXkh2C4cjsVRx+xwB+cWzKDApB/DdGCr/X 2gD3Xyaes4yIQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mail.sberdevices.ru (Postfix) with ESMTP; Mon, 18 Jul 2022 11:18:20 +0300 (MSK) From: Arseniy Krasnov To: Stefano Garzarella , "David S. Miller" , "edumazet@google.com" , "Jakub Kicinski" , Paolo Abeni , Stefan Hajnoczi , "Michael S. Tsirkin" , Arseniy Krasnov , Krasnov Arseniy CC: "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "netdev@vger.kernel.org" , "kvm@vger.kernel.org" , kernel Subject: [RFC PATCH v1 2/3] virtio/vsock: use 'target' in notify_poll_in, callback. Thread-Topic: [RFC PATCH v1 2/3] virtio/vsock: use 'target' in notify_poll_in, callback. Thread-Index: AQHYmn7T+PqKYxwQ8USiiecixCHJYQ== Date: Mon, 18 Jul 2022 08:17:31 +0000 Message-ID: <358f8d52-fd88-ad2e-87e2-c64bfa516a58@sberdevices.ru> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.1.12] Content-ID: <6A2B7E3D9075EA4E817DC70C89877970@sberdevices.ru> MIME-Version: 1.0 X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/07/18 02:31:00 #19923013 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-State: RFC This callback controls setting of POLLIN,POLLRDNORM output bits of poll() syscall,but in some cases,it is incorrectly to set it, when socket has at least 1 bytes of available data. Use 'target' which is already exists and equal to sk_rcvlowat in this case. Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/virtio_transport_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index ec2c2afbf0d0..591908740992 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -634,7 +634,7 @@ virtio_transport_notify_poll_in(struct vsock_sock *vsk, size_t target, bool *data_ready_now) { - if (vsock_stream_has_data(vsk)) + if (vsock_stream_has_data(vsk) >= target) *data_ready_now = true; else *data_ready_now = false;