diff mbox series

[v2,net-next] ethernet: Make OA_TC6 config symbol invisible

Message ID 3b600550745af10ab7d7c3526353931c1d39f641.1733994552.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Commit 0193eebbb1fcade01331f9d7cc24e57fc28a577d
Delegated to: Netdev Maintainers
Headers show
Series [v2,net-next] ethernet: Make OA_TC6 config symbol invisible | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: masahiroy@kernel.org
netdev/build_clang success Errors and warnings before: 1 this patch: 1
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 5 this patch: 5
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-12-13--15-00 (tests: 795)

Commit Message

Geert Uytterhoeven Dec. 12, 2024, 9:11 a.m. UTC
Commit aa58bec064ab1622 ("net: ethernet: oa_tc6: implement register
write operation") introduced a library that implements the OPEN Alliance
TC6 10BASE-T1x MAC-PHY Serial Interface protocol for supporting
10BASE-T1x MAC-PHYs.

There is no need to ask the user about enabling this library, as all
drivers that use it select the OA_TC6 symbol.  Hence make the symbol
invisible, unless when compile-testing.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Target at net-next instead on net, as suggested by Simon,
  - Replace Fixes-tag by description, as suggested by Simon.
---
 drivers/net/ethernet/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Horman Dec. 13, 2024, 11:26 a.m. UTC | #1
On Thu, Dec 12, 2024 at 10:11:43AM +0100, Geert Uytterhoeven wrote:
> Commit aa58bec064ab1622 ("net: ethernet: oa_tc6: implement register
> write operation") introduced a library that implements the OPEN Alliance
> TC6 10BASE-T1x MAC-PHY Serial Interface protocol for supporting
> 10BASE-T1x MAC-PHYs.
> 
> There is no need to ask the user about enabling this library, as all
> drivers that use it select the OA_TC6 symbol.  Hence make the symbol
> invisible, unless when compile-testing.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Target at net-next instead on net, as suggested by Simon,
>   - Replace Fixes-tag by description, as suggested by Simon.

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org Dec. 15, 2024, 10 p.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 12 Dec 2024 10:11:43 +0100 you wrote:
> Commit aa58bec064ab1622 ("net: ethernet: oa_tc6: implement register
> write operation") introduced a library that implements the OPEN Alliance
> TC6 10BASE-T1x MAC-PHY Serial Interface protocol for supporting
> 10BASE-T1x MAC-PHYs.
> 
> There is no need to ask the user about enabling this library, as all
> drivers that use it select the OA_TC6 symbol.  Hence make the symbol
> invisible, unless when compile-testing.
> 
> [...]

Here is the summary with links:
  - [v2,net-next] ethernet: Make OA_TC6 config symbol invisible
    https://git.kernel.org/netdev/net-next/c/0193eebbb1fc

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index 9a542e3c9b05d877..977b42bc1e8c1e88 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -159,7 +159,7 @@  config ETHOC
 	  Say Y here if you want to use the OpenCores 10/100 Mbps Ethernet MAC.
 
 config OA_TC6
-	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support"
+	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support" if COMPILE_TEST
 	depends on SPI
 	select PHYLIB
 	help