| Message ID | 3e394d4cf8204bcf17b184bfda474085aa8ed0dd.1738771631.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ec7309525a37b3f34c4efa85fc2ecaa65f41830e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: pcs: rzn1-miic: Convert to for_each_available_child_of_node() helper | expand |
On Wed, Feb 05, 2025 at 05:09:47PM +0100, Geert Uytterhoeven wrote: > Simplify miic_parse_dt() by using the for_each_available_child_of_node() > helper instead of manually skipping unavailable child nodes. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 5 Feb 2025 17:09:47 +0100 you wrote: > Simplify miic_parse_dt() by using the for_each_available_child_of_node() > helper instead of manually skipping unavailable child nodes. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/pcs/pcs-rzn1-miic.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Here is the summary with links: - [net-next] net: pcs: rzn1-miic: Convert to for_each_available_child_of_node() helper https://git.kernel.org/netdev/net-next/c/ec7309525a37 You are awesome, thank you!
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c index 74a1c28ffc014796..991f05a40c758ccd 100644 --- a/drivers/net/pcs/pcs-rzn1-miic.c +++ b/drivers/net/pcs/pcs-rzn1-miic.c @@ -472,13 +472,10 @@ static int miic_parse_dt(struct device *dev, u32 *mode_cfg) if (of_property_read_u32(np, "renesas,miic-switch-portin", &conf) == 0) dt_val[0] = conf; - for_each_child_of_node(np, conv) { + for_each_available_child_of_node(np, conv) { if (of_property_read_u32(conv, "reg", &port)) continue; - if (!of_device_is_available(conv)) - continue; - if (of_property_read_u32(conv, "renesas,miic-input", &conf) == 0) dt_val[port] = conf; }
Simplify miic_parse_dt() by using the for_each_available_child_of_node() helper instead of manually skipping unavailable child nodes. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/pcs/pcs-rzn1-miic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)