| Message ID | 46cd3872bef7854dbdb3cc41161a65147f4a7e2c.1714046812.git.siyanteng@loongson.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | stmmac: Add Loongson platform support | expand |
On Thu, Apr 25, 2024 at 09:04:36PM +0800, Yanteng Si wrote: > Just use PCI_DEVICE_DATA() macro for device identification, > No changes to function functionality. Some more verbose commit log: "For the readability sake convert the hard-coded Loongson GMAC PCI ID to the respective macro and use the PCI_DEVICE_DATA() macro-function to create the pci_device_id array entry. The later change will be specifically useful in order to assign the device-specific data for the currently supported device and for about to be added Loongson GNET controller." Other than that the change looks good: Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > > Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn> > Signed-off-by: Yinggang Gu <guyinggang@loongson.cn> > Signed-off-by: Yanteng Si <siyanteng@loongson.cn> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > index 19906ea67636..4e0838db4259 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > @@ -9,6 +9,8 @@ > #include <linux/of_irq.h> > #include "stmmac.h" > > +#define PCI_DEVICE_ID_LOONGSON_GMAC 0x7a03 > + > static int loongson_default_data(struct plat_stmmacenet_data *plat) > { > plat->clk_csr = 2; /* clk_csr_i = 20-35MHz & MDC = clk_csr_i/16 */ > @@ -210,7 +212,7 @@ static SIMPLE_DEV_PM_OPS(loongson_dwmac_pm_ops, loongson_dwmac_suspend, > loongson_dwmac_resume); > > static const struct pci_device_id loongson_dwmac_id_table[] = { > - { PCI_VDEVICE(LOONGSON, 0x7a03) }, > + { PCI_DEVICE_DATA(LOONGSON, GMAC, NULL) }, > {} > }; > MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table); > -- > 2.31.4 >
在 2024/5/3 21:43, Serge Semin 写道: > On Thu, Apr 25, 2024 at 09:04:36PM +0800, Yanteng Si wrote: >> Just use PCI_DEVICE_DATA() macro for device identification, >> No changes to function functionality. > Some more verbose commit log: > > "For the readability sake convert the hard-coded Loongson GMAC PCI ID to > the respective macro and use the PCI_DEVICE_DATA() macro-function to > create the pci_device_id array entry. The later change will be > specifically useful in order to assign the device-specific data for the > currently supported device and for about to be added Loongson GNET > controller." > > Other than that the change looks good: > > Reviewed-by: Serge Semin<fancer.lancer@gmail.com> OK, Thanks! Thanks, Yanteng
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index 19906ea67636..4e0838db4259 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -9,6 +9,8 @@ #include <linux/of_irq.h> #include "stmmac.h" +#define PCI_DEVICE_ID_LOONGSON_GMAC 0x7a03 + static int loongson_default_data(struct plat_stmmacenet_data *plat) { plat->clk_csr = 2; /* clk_csr_i = 20-35MHz & MDC = clk_csr_i/16 */ @@ -210,7 +212,7 @@ static SIMPLE_DEV_PM_OPS(loongson_dwmac_pm_ops, loongson_dwmac_suspend, loongson_dwmac_resume); static const struct pci_device_id loongson_dwmac_id_table[] = { - { PCI_VDEVICE(LOONGSON, 0x7a03) }, + { PCI_DEVICE_DATA(LOONGSON, GMAC, NULL) }, {} }; MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table);