diff mbox series

[RFC,net-next,3/3] net: ngbe: add support for ncsi nics

Message ID 5050D7292AC40763+20230605095527.57898-4-mengyuanlou@net-swift.com (mailing list archive)
State RFC
Delegated to: Netdev Maintainers
Headers show
Series wangxun nics add wol ncsi support | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next, async
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/cc_maintainers warning 4 maintainers not CCed: kuba@kernel.org edumazet@google.com davem@davemloft.net pabeni@redhat.com
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Mengyuan Lou June 5, 2023, 9:52 a.m. UTC 
Pass ncsi_enabled through netdev to phy_supsend().
when ncsi_enabled is on, phy should not to supsend.

Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
---
 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman June 5, 2023, 1:31 p.m. UTC | #1 
On Mon, Jun 05, 2023 at 05:52:52PM +0800, Mengyuan Lou wrote:
> Pass ncsi_enabled through netdev to phy_supsend().
> when ncsi_enabled is on, phy should not to supsend.

Hi Mengyuan Lou,

a minor nit from my side: 'supsend' -> 'suspend'
diff mbox series

Patch

diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
index 5d013ac3acd1..37d5e1f12d19 100644
--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
+++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
@@ -629,6 +629,7 @@  static int ngbe_probe(struct pci_dev *pdev,
 
 	device_set_wakeup_enable(&pdev->dev, wx->wol);
 	netdev->wol_enabled = wx->wol_enabled;
+	netdev->ncsi_enabled = wx->ncsi_enabled;
 
 	/* Save off EEPROM version number and Option Rom version which
 	 * together make a unique identify for the eeprom