| Message ID | 5290b224a23e36b22e179ca83f2ce377f6d8dd1c.1685396319.git.aclaudi@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b2c6613ef955e6e10c3acadc852057686ffcf721 |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2] vdpa: propagate error from cmd_dev_vstats_show() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
> From: Andrea Claudi <aclaudi@redhat.com> > Sent: Monday, May 29, 2023 5:42 PM > > Error potentially returned from mnlu_gen_socket_sndrcv() are propagated for > each and every invocation in vdpa. Let's do the same here. > > Fixes: 6f97e9c9337b ("vdpa: Add support for reading vdpa device statistics") > Signed-off-by: Andrea Claudi <aclaudi@redhat.com> > --- > vdpa/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c > index 27647d73..8bbe452c 100644 > --- a/vdpa/vdpa.c > +++ b/vdpa/vdpa.c > @@ -986,7 +986,7 @@ static int cmd_dev_vstats_show(struct vdpa *vdpa, int > argc, char **argv) > pr_out_section_start(vdpa, "vstats"); > err = mnlu_gen_socket_sndrcv(&vdpa->nlg, nlh, > cmd_dev_vstats_show_cb, vdpa); > pr_out_section_end(vdpa); > - return 0; > + return err; > } > > static int cmd_dev_vstats(struct vdpa *vdpa, int argc, char **argv) > -- > 2.40.1 Reviewed-by: Parav Pandit <parav@nvidia.com>
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Mon, 29 May 2023 23:41:41 +0200 you wrote: > Error potentially returned from mnlu_gen_socket_sndrcv() are propagated > for each and every invocation in vdpa. Let's do the same here. > > Fixes: 6f97e9c9337b ("vdpa: Add support for reading vdpa device statistics") > Signed-off-by: Andrea Claudi <aclaudi@redhat.com> > --- > vdpa/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [iproute2] vdpa: propagate error from cmd_dev_vstats_show() https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=b2c6613ef955 You are awesome, thank you!
diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c index 27647d73..8bbe452c 100644 --- a/vdpa/vdpa.c +++ b/vdpa/vdpa.c @@ -986,7 +986,7 @@ static int cmd_dev_vstats_show(struct vdpa *vdpa, int argc, char **argv) pr_out_section_start(vdpa, "vstats"); err = mnlu_gen_socket_sndrcv(&vdpa->nlg, nlh, cmd_dev_vstats_show_cb, vdpa); pr_out_section_end(vdpa); - return 0; + return err; } static int cmd_dev_vstats(struct vdpa *vdpa, int argc, char **argv)
Error potentially returned from mnlu_gen_socket_sndrcv() are propagated for each and every invocation in vdpa. Let's do the same here. Fixes: 6f97e9c9337b ("vdpa: Add support for reading vdpa device statistics") Signed-off-by: Andrea Claudi <aclaudi@redhat.com> --- vdpa/vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)