| Message ID | 52d0814a-7287-4160-94b5-ac7939ac61c6@moroto.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bc758ade614576d1c1b167af0246ada8c916c804 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net/mlx4: clean up a type issue | expand |
Hi Dan, On 7/24/23 22:39, Dan Carpenter wrote: > These functions returns type bool, not pointers, so return false instead > of NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> LGTM. Thanks. Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > --- > Not a bug. Targetting net-next. > > drivers/net/ethernet/mellanox/mlx4/mcg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c > index f1716a83a4d3..24d0c7c46878 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c > +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c > @@ -294,7 +294,7 @@ static bool check_duplicate_entry(struct mlx4_dev *dev, u8 port, > struct mlx4_promisc_qp *dqp, *tmp_dqp; > > if (port < 1 || port > dev->caps.num_ports) > - return NULL; > + return false; > > s_steer = &mlx4_priv(dev)->steer[port - 1]; > > @@ -375,7 +375,7 @@ static bool can_remove_steering_entry(struct mlx4_dev *dev, u8 port, > bool ret = false; > > if (port < 1 || port > dev->caps.num_ports) > - return NULL; > + return false; > > s_steer = &mlx4_priv(dev)->steer[port - 1]; >
On Tue, Jul 25, 2023 at 08:39:47AM +0300, Dan Carpenter wrote: > These functions returns type bool, not pointers, so return false instead > of NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > Not a bug. Targetting net-next. > > drivers/net/ethernet/mellanox/mlx4/mcg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On 25/07/2023 8:39, Dan Carpenter wrote: > These functions returns type bool, not pointers, so return false instead > of NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > Not a bug. Targetting net-next. > > drivers/net/ethernet/mellanox/mlx4/mcg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c > index f1716a83a4d3..24d0c7c46878 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c > +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c > @@ -294,7 +294,7 @@ static bool check_duplicate_entry(struct mlx4_dev *dev, u8 port, > struct mlx4_promisc_qp *dqp, *tmp_dqp; > > if (port < 1 || port > dev->caps.num_ports) > - return NULL; > + return false; > > s_steer = &mlx4_priv(dev)->steer[port - 1]; > > @@ -375,7 +375,7 @@ static bool can_remove_steering_entry(struct mlx4_dev *dev, u8 port, > bool ret = false; > > if (port < 1 || port > dev->caps.num_ports) > - return NULL; > + return false; > > s_steer = &mlx4_priv(dev)->steer[port - 1]; > Thanks for your patch. Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 25 Jul 2023 08:39:47 +0300 you wrote: > These functions returns type bool, not pointers, so return false instead > of NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > Not a bug. Targetting net-next. > > [...] Here is the summary with links: - [net-next] net/mlx4: clean up a type issue https://git.kernel.org/netdev/net-next/c/bc758ade6145 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c index f1716a83a4d3..24d0c7c46878 100644 --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c @@ -294,7 +294,7 @@ static bool check_duplicate_entry(struct mlx4_dev *dev, u8 port, struct mlx4_promisc_qp *dqp, *tmp_dqp; if (port < 1 || port > dev->caps.num_ports) - return NULL; + return false; s_steer = &mlx4_priv(dev)->steer[port - 1]; @@ -375,7 +375,7 @@ static bool can_remove_steering_entry(struct mlx4_dev *dev, u8 port, bool ret = false; if (port < 1 || port > dev->caps.num_ports) - return NULL; + return false; s_steer = &mlx4_priv(dev)->steer[port - 1];
These functions returns type bool, not pointers, so return false instead of NULL. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- Not a bug. Targetting net-next. drivers/net/ethernet/mellanox/mlx4/mcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)