Message ID | 599e6c1fdcc50f16597380118c9b3b6790241d50.1627439903.git.marcelo.leitner@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 557fb5862c9272ad9b21407afe1da8acfd9b53eb |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net] sctp: fix return value check in __sctp_rcv_asconf_lookup | expand |
Context | Check | Description |
---|---|---|
netdev/cover_letter | success | Link |
netdev/fixes_present | success | Link |
netdev/patch_count | success | Link |
netdev/tree_selection | success | Clearly marked for net |
netdev/subject_prefix | success | Link |
netdev/cc_maintainers | fail | 1 blamed authors not CCed: davem@davemloft.net; 4 maintainers not CCed: vyasevich@gmail.com davem@davemloft.net nhorman@tuxdriver.com kuba@kernel.org |
netdev/source_inline | success | Was 0 now: 0 |
netdev/verify_signedoff | success | Link |
netdev/module_param | success | Was 0 now: 0 |
netdev/build_32bit | success | Errors and warnings before: 3 this patch: 3 |
netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
netdev/verify_fixes | success | Link |
netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
netdev/build_allmodconfig_warn | success | Errors and warnings before: 3 this patch: 3 |
netdev/header_inline | success | Link |
On Tue, Jul 27, 2021 at 10:41 PM Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote: > > As Ben Hutchings noticed, this check should have been inverted: the call > returns true in case of success. > > Reported-by: Ben Hutchings <ben@decadent.org.uk> > Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return") > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > --- > net/sctp/input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/input.c b/net/sctp/input.c > index eb3c2a34a31c64d5322f326613f4a4a02f8c902e..5ef86fdb11769d9c8a32219c5c7361fc34217b02 100644 > --- a/net/sctp/input.c > +++ b/net/sctp/input.c > @@ -1203,7 +1203,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( > if (unlikely(!af)) > return NULL; > > - if (af->from_addr_param(&paddr, param, peer_port, 0)) > + if (!af->from_addr_param(&paddr, param, peer_port, 0)) > return NULL; > > return __sctp_lookup_association(net, laddr, &paddr, transportp); > -- > 2.31.1 > Reviewed-by: Xin Long <lucien.xin@gmail.com>
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 27 Jul 2021 23:40:54 -0300 you wrote: > As Ben Hutchings noticed, this check should have been inverted: the call > returns true in case of success. > > Reported-by: Ben Hutchings <ben@decadent.org.uk> > Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return") > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> > > [...] Here is the summary with links: - [net] sctp: fix return value check in __sctp_rcv_asconf_lookup https://git.kernel.org/netdev/net/c/557fb5862c92 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/net/sctp/input.c b/net/sctp/input.c index eb3c2a34a31c64d5322f326613f4a4a02f8c902e..5ef86fdb11769d9c8a32219c5c7361fc34217b02 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1203,7 +1203,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( if (unlikely(!af)) return NULL; - if (af->from_addr_param(&paddr, param, peer_port, 0)) + if (!af->from_addr_param(&paddr, param, peer_port, 0)) return NULL; return __sctp_lookup_association(net, laddr, &paddr, transportp);
As Ben Hutchings noticed, this check should have been inverted: the call returns true in case of success. Reported-by: Ben Hutchings <ben@decadent.org.uk> Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return") Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> --- net/sctp/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)