diff mbox series

[net] igc: Unlock on error in igc_io_resume()

Message ID 64a982d3-a2f5-4ef7-ad75-61f6bb1fae24@stanley.mountain (mailing list archive)
State Accepted
Commit ef4a99a0164e3972abb421cbb1b09ea6c61414df
Delegated to: Netdev Maintainers
Headers show
Series [net] igc: Unlock on error in igc_io_resume() | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 16 this patch: 16
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 16 this patch: 16
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 16 this patch: 16
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 29 this patch: 29
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-08-30--06-00 (tests: 714)

Commit Message

Dan Carpenter Aug. 29, 2024, 7:22 p.m. UTC 
Call rtnl_unlock() on this error path, before returning.

Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Gerhard Engleder Aug. 29, 2024, 7:26 p.m. UTC | #1 
On 29.08.24 21:22, Dan Carpenter wrote:
> Call rtnl_unlock() on this error path, before returning.
> 
> Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index dfd6c00b4205..0a095cdea4fb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -7413,6 +7413,7 @@ static void igc_io_resume(struct pci_dev *pdev)
>   	rtnl_lock();
>   	if (netif_running(netdev)) {
>   		if (igc_open(netdev)) {
> +			rtnl_unlock();
>   			netdev_err(netdev, "igc_open failed after reset\n");
>   			return;
>   		}

Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
patchwork-bot+netdevbpf@kernel.org Sept. 2, 2024, 12:50 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 29 Aug 2024 22:22:45 +0300 you wrote:
> Call rtnl_unlock() on this error path, before returning.
> 
> Fixes: bc23aa949aeb ("igc: Add pcie error handler support")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - [net] igc: Unlock on error in igc_io_resume()
    https://git.kernel.org/netdev/net/c/ef4a99a0164e

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index dfd6c00b4205..0a095cdea4fb 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -7413,6 +7413,7 @@  static void igc_io_resume(struct pci_dev *pdev)
 	rtnl_lock();
 	if (netif_running(netdev)) {
 		if (igc_open(netdev)) {
+			rtnl_unlock();
 			netdev_err(netdev, "igc_open failed after reset\n");
 			return;
 		}