| Message ID | 72bc8926dcfc471ce385494f2c8c23398f8761d2.1630415944.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: NET_VENDOR_LITEX should depend on LITEX | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > LiteX Ethernet devices are only present on LiteX SoCs. Hence add a > dependency on LITEX, to prevent asking the user about drivers for these > devices when configuring a kernel without LiteX SoC Builder support. nak. They can be present on any soc that uses them. We have an example in mainline already; microwatt uses liteeth but is not a litex soc. Cheers, Joel > > Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/net/ethernet/litex/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig > index 265dba414b41ec22..bfad1df1368866d3 100644 > --- a/drivers/net/ethernet/litex/Kconfig > +++ b/drivers/net/ethernet/litex/Kconfig > @@ -5,6 +5,7 @@ > config NET_VENDOR_LITEX > bool "LiteX devices" > default y > + depends on LITEX || COMPILE_TEST > help > If you have a network (Ethernet) card belonging to this class, say Y. > > -- > 2.25.1 >
Hi Joel, On Tue, Aug 31, 2021 at 3:37 PM Joel Stanley <joel@jms.id.au> wrote: > On Tue, 31 Aug 2021 at 13:21, Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > > LiteX Ethernet devices are only present on LiteX SoCs. Hence add a > > dependency on LITEX, to prevent asking the user about drivers for these > > devices when configuring a kernel without LiteX SoC Builder support. > > nak. > > They can be present on any soc that uses them. We have an example in > mainline already; microwatt uses liteeth but is not a litex soc. But liiteeth.c uses <linux/litex.h>? And https://github.com/enjoy-digital/litex can be used with a microwatt CPU core? The idea behind the LITEX config symbol was to gate off any driver using LiteX interfaces. > > Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- a/drivers/net/ethernet/litex/Kconfig > > +++ b/drivers/net/ethernet/litex/Kconfig > > @@ -5,6 +5,7 @@ > > config NET_VENDOR_LITEX > > bool "LiteX devices" > > default y > > + depends on LITEX || COMPILE_TEST > > help > > If you have a network (Ethernet) card belonging to this class, say Y. Gr{oetje,eeting}s, Geert
diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig index 265dba414b41ec22..bfad1df1368866d3 100644 --- a/drivers/net/ethernet/litex/Kconfig +++ b/drivers/net/ethernet/litex/Kconfig @@ -5,6 +5,7 @@ config NET_VENDOR_LITEX bool "LiteX devices" default y + depends on LITEX || COMPILE_TEST help If you have a network (Ethernet) card belonging to this class, say Y.
LiteX Ethernet devices are only present on LiteX SoCs. Hence add a dependency on LITEX, to prevent asking the user about drivers for these devices when configuring a kernel without LiteX SoC Builder support. Fixes: ee7da21ac4c3be1f ("net: Add driver for LiteX's LiteETH network interface") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/ethernet/litex/Kconfig | 1 + 1 file changed, 1 insertion(+)