| Message ID | 7b85ce0d2a5056af2c7e14dbd16c55d86aac659c.1632420431.git.leonro@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 61415c3db3d98c74bfe8f9e8688b6e40b4c3e1d4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Batch of devlink related fixes | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 31 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Thu, Sep 23, 2021 at 11:13 AM Leon Romanovsky <leon@kernel.org> wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > > This driver doesn't have any port parameters and registers > devlink port parameters with empty table. Remove the useless > calls to devlink_port_params_register and _unregister. > > Fixes: da203dfa89ce ("Revert "devlink: Add a generic wake_on_lan port parameter"") > Signed-off-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > index dc0851f709f5..ed95e28d60ef 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c > @@ -736,9 +736,6 @@ static const struct devlink_param bnxt_dl_params[] = { > NULL), > }; > > -static const struct devlink_param bnxt_dl_port_params[] = { > -}; > - > static int bnxt_dl_params_register(struct bnxt *bp) > { > int rc; > @@ -753,14 +750,6 @@ static int bnxt_dl_params_register(struct bnxt *bp) > rc); > return rc; > } > - rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, > - ARRAY_SIZE(bnxt_dl_port_params)); > - if (rc) { > - netdev_err(bp->dev, "devlink_port_params_register failed\n"); > - devlink_params_unregister(bp->dl, bnxt_dl_params, > - ARRAY_SIZE(bnxt_dl_params)); > - return rc; > - } > devlink_params_publish(bp->dl); > > return 0; > @@ -773,8 +762,6 @@ static void bnxt_dl_params_unregister(struct bnxt *bp) > > devlink_params_unregister(bp->dl, bnxt_dl_params, > ARRAY_SIZE(bnxt_dl_params)); > - devlink_port_params_unregister(&bp->dl_port, bnxt_dl_port_params, > - ARRAY_SIZE(bnxt_dl_port_params)); > } > > int bnxt_dl_register(struct bnxt *bp) > -- > 2.31.1 > Ah, looks like the revert in da203dfa89ce wasn't complete. Thanks for the cleanup. Reviewed-by: Edwin Peer <edwin.peer@broadcom.com> Regards, Edwin Peer
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index dc0851f709f5..ed95e28d60ef 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -736,9 +736,6 @@ static const struct devlink_param bnxt_dl_params[] = { NULL), }; -static const struct devlink_param bnxt_dl_port_params[] = { -}; - static int bnxt_dl_params_register(struct bnxt *bp) { int rc; @@ -753,14 +750,6 @@ static int bnxt_dl_params_register(struct bnxt *bp) rc); return rc; } - rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, - ARRAY_SIZE(bnxt_dl_port_params)); - if (rc) { - netdev_err(bp->dev, "devlink_port_params_register failed\n"); - devlink_params_unregister(bp->dl, bnxt_dl_params, - ARRAY_SIZE(bnxt_dl_params)); - return rc; - } devlink_params_publish(bp->dl); return 0; @@ -773,8 +762,6 @@ static void bnxt_dl_params_unregister(struct bnxt *bp) devlink_params_unregister(bp->dl, bnxt_dl_params, ARRAY_SIZE(bnxt_dl_params)); - devlink_port_params_unregister(&bp->dl_port, bnxt_dl_port_params, - ARRAY_SIZE(bnxt_dl_port_params)); } int bnxt_dl_register(struct bnxt *bp)