diff mbox series

[net-next,v3,1/2] dt-bindings: net: marvell,aquantia: add property to override MDI_CFG

Message ID 7ccf25d6d7859f1ce9983c81a2051cfdfb0e0a99.1728058550.git.daniel@makrotopia.org (mailing list archive)
State Accepted
Commit 1432965bf5ce0c866924a66be391e478a98e69ee
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v3,1/2] dt-bindings: net: marvell,aquantia: add property to override MDI_CFG | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 5 this patch: 5
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-06--15-00 (tests: 775)

Commit Message

Daniel Golle Oct. 4, 2024, 4:18 p.m. UTC
Usually the MDI pair order reversal configuration is defined by
bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI
pair order and force either normal or reverse order.

Add property 'marvell,mdi-cfg-order' to allow forcing either normal or
reverse order of the MDI pairs.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
v3: use integer enum instead of two properties as suggested
v2: enforce mutually exclusive relationship of the two new properties in
    dt-schema.

 Documentation/devicetree/bindings/net/marvell,aquantia.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring (Arm) Oct. 5, 2024, 6:46 p.m. UTC | #1
On Fri, 04 Oct 2024 17:18:05 +0100, Daniel Golle wrote:
> Usually the MDI pair order reversal configuration is defined by
> bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI
> pair order and force either normal or reverse order.
> 
> Add property 'marvell,mdi-cfg-order' to allow forcing either normal or
> reverse order of the MDI pairs.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> v3: use integer enum instead of two properties as suggested
> v2: enforce mutually exclusive relationship of the two new properties in
>     dt-schema.
> 
>  Documentation/devicetree/bindings/net/marvell,aquantia.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
patchwork-bot+netdevbpf@kernel.org Oct. 9, 2024, 12:20 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 4 Oct 2024 17:18:05 +0100 you wrote:
> Usually the MDI pair order reversal configuration is defined by
> bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI
> pair order and force either normal or reverse order.
> 
> Add property 'marvell,mdi-cfg-order' to allow forcing either normal or
> reverse order of the MDI pairs.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/2] dt-bindings: net: marvell,aquantia: add property to override MDI_CFG
    https://git.kernel.org/netdev/net-next/c/1432965bf5ce
  - [net-next,v3,2/2] net: phy: aquantia: allow forcing order of MDI pairs
    https://git.kernel.org/netdev/net-next/c/a2e1ba275eae

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml
index 9854fab4c4db..f269615126d8 100644
--- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml
+++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml
@@ -48,6 +48,12 @@  properties:
   firmware-name:
     description: specify the name of PHY firmware to load
 
+  marvell,mdi-cfg-order:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [0, 1]
+    description:
+      force normal (0) or reverse (1) order of MDI pairs, overriding MDI_CFG bootstrap pin.
+
   nvmem-cells:
     description: phandle to the firmware nvmem cell
     maxItems: 1