| Message ID | 7e30b8e01fdfb76ff6f4e071348829e2f56767e8.1632477544.git.petrm@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b69c99463d414cc263411462d52f25205657e9af |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] selftests: net: fib_nexthops: Wait before checking reported idle time | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/subject_prefix | success | Link |
| netdev/cc_maintainers | warning | 2 maintainers not CCed: linux-kselftest@vger.kernel.org shuah@kernel.org |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 24 Sep 2021 12:04:27 +0200 you wrote: > The purpose of this test is to verify that after a short activity passes, > the reported time is reasonable: not zero (which could be reported by > mistake), and not something outrageous (which would be indicative of an > issue in used units). > > However, the idle time is reported in units of clock_t, or hundredths of > second. If the initial sequence of commands is very quick, it is possible > that the idle time is reported as just flat-out zero. When this test was > recently enabled in our nightly regression, we started seeing spurious > failures for exactly this reason. > > [...] Here is the summary with links: - [net-next] selftests: net: fib_nexthops: Wait before checking reported idle time https://git.kernel.org/netdev/net-next/c/b69c99463d41 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh index 0d293391e9a4..b5a69ad191b0 100755 --- a/tools/testing/selftests/net/fib_nexthops.sh +++ b/tools/testing/selftests/net/fib_nexthops.sh @@ -2078,6 +2078,7 @@ basic_res() "id 101 index 0 nhid 2 id 101 index 1 nhid 2 id 101 index 2 nhid 1 id 101 index 3 nhid 1" log_test $? 0 "Dump all nexthop buckets in a group" + sleep 0.1 (( $($IP -j nexthop bucket list id 101 | jq '[.[] | select(.bucket.idle_time > 0 and .bucket.idle_time < 2)] | length') == 4 ))
The purpose of this test is to verify that after a short activity passes, the reported time is reasonable: not zero (which could be reported by mistake), and not something outrageous (which would be indicative of an issue in used units). However, the idle time is reported in units of clock_t, or hundredths of second. If the initial sequence of commands is very quick, it is possible that the idle time is reported as just flat-out zero. When this test was recently enabled in our nightly regression, we started seeing spurious failures for exactly this reason. Therefore buffer the delay leading up to the test with a sleep, to make sure there is no legitimate way of reporting 0. Signed-off-by: Petr Machata <petrm@nvidia.com> --- tools/testing/selftests/net/fib_nexthops.sh | 1 + 1 file changed, 1 insertion(+)