| Message ID | 7ef2e230-dfb7-4a77-8973-9e5be1a99fc2@moroto.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 87c33315af380ca12a2e59ac94edad4fe0481b4c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: phy: air_en8811h: fix some error codes | expand |
On Fri, Apr 05, 2024 at 01:08:59PM +0300, Dan Carpenter wrote: > These error paths accidentally return "ret" which is zero/success > instead of the correct error code. > > Fixes: 71e79430117d ("net: phy: air_en8811h: Add the Airoha EN8811H PHY driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 5 Apr 2024 13:08:59 +0300 you wrote: > These error paths accidentally return "ret" which is zero/success > instead of the correct error code. > > Fixes: 71e79430117d ("net: phy: air_en8811h: Add the Airoha EN8811H PHY driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/net/phy/air_en8811h.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Here is the summary with links: - [net-next] net: phy: air_en8811h: fix some error codes https://git.kernel.org/netdev/net-next/c/87c33315af38 You are awesome, thank you!
diff --git a/drivers/net/phy/air_en8811h.c b/drivers/net/phy/air_en8811h.c index 720542a4fd82..4c9a1c9c805e 100644 --- a/drivers/net/phy/air_en8811h.c +++ b/drivers/net/phy/air_en8811h.c @@ -272,11 +272,11 @@ static int __air_buckpbus_reg_read(struct phy_device *phydev, pbus_data_high = __phy_read(phydev, AIR_BPBUS_RD_DATA_HIGH); if (pbus_data_high < 0) - return ret; + return pbus_data_high; pbus_data_low = __phy_read(phydev, AIR_BPBUS_RD_DATA_LOW); if (pbus_data_low < 0) - return ret; + return pbus_data_low; *pbus_data = pbus_data_low | (pbus_data_high << 16); return 0; @@ -323,11 +323,11 @@ static int __air_buckpbus_reg_modify(struct phy_device *phydev, pbus_data_high = __phy_read(phydev, AIR_BPBUS_RD_DATA_HIGH); if (pbus_data_high < 0) - return ret; + return pbus_data_high; pbus_data_low = __phy_read(phydev, AIR_BPBUS_RD_DATA_LOW); if (pbus_data_low < 0) - return ret; + return pbus_data_low; pbus_data_old = pbus_data_low | (pbus_data_high << 16); pbus_data_new = (pbus_data_old & ~mask) | set;
These error paths accidentally return "ret" which is zero/success instead of the correct error code. Fixes: 71e79430117d ("net: phy: air_en8811h: Add the Airoha EN8811H PHY driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/net/phy/air_en8811h.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)