| Message ID | 830637dd-4016-4a68-92b3-618fcac6589d@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | faac69a4ae5abb49e62c79c66b51bb905c9aa5ec |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] r8169: don't scan PHY addresses > 0 | expand |
On Tue, Feb 04, 2025 at 07:58:17AM +0100, Heiner Kallweit wrote: > The PHY address is a dummy, because r8169 PHY access registers > don't support a PHY address. Therefore scan address 0 only. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 4 Feb 2025 07:58:17 +0100 you wrote: > The PHY address is a dummy, because r8169 PHY access registers > don't support a PHY address. Therefore scan address 0 only. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > v2: > - Because of the IOCTL interface, don't remove the phyaddr > 0 checks. > > [...] Here is the summary with links: - [v2,net-next] r8169: don't scan PHY addresses > 0 https://git.kernel.org/netdev/net-next/c/faac69a4ae5a You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 5a5eba49c..7306c8e32 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5222,6 +5222,7 @@ static int r8169_mdio_register(struct rtl8169_private *tp) new_bus->priv = tp; new_bus->parent = &pdev->dev; new_bus->irq[0] = PHY_MAC_INTERRUPT; + new_bus->phy_mask = GENMASK(31, 1); snprintf(new_bus->id, MII_BUS_ID_SIZE, "r8169-%x-%x", pci_domain_nr(pdev->bus), pci_dev_id(pdev));
The PHY address is a dummy, because r8169 PHY access registers don't support a PHY address. Therefore scan address 0 only. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- v2: - Because of the IOCTL interface, don't remove the phyaddr > 0 checks. --- drivers/net/ethernet/realtek/r8169_main.c | 1 + 1 file changed, 1 insertion(+)