| Message ID | 84432fe4-0be4-bc82-4e5c-557206b40f56@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 69ff53e4a4c9498eeed7d1441f68a1481dc69251 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 2 Feb 2023 21:45:36 +0100 you wrote: > Jerome provided the information that also the GXL internal PHY doesn't > support MMD register access and EEE. MMD reads return 0xffff, what > results in e.g. completely wrong ethtool --show-eee output. > Therefore use the MMD dummy stubs. > > v2: > - Change Fixes tag to the actually offending commit. As 4.9 is EOL > this fix will apply on all stable versions. > > [...] Here is the summary with links: - [v2,net] net: phy: meson-gxl: use MMD access dummy stubs for GXL, internal PHY https://git.kernel.org/netdev/net/c/69ff53e4a4c9 You are awesome, thank you!
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index c49062ad7..fbf5f2416 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -261,6 +261,8 @@ static struct phy_driver meson_gxl_phy[] = { .handle_interrupt = meson_gxl_handle_interrupt, .suspend = genphy_suspend, .resume = genphy_resume, + .read_mmd = genphy_read_mmd_unsupported, + .write_mmd = genphy_write_mmd_unsupported, }, { PHY_ID_MATCH_EXACT(0x01803301), .name = "Meson G12A Internal PHY",
Jerome provided the information that also the GXL internal PHY doesn't support MMD register access and EEE. MMD reads return 0xffff, what results in e.g. completely wrong ethtool --show-eee output. Therefore use the MMD dummy stubs. v2: - Change Fixes tag to the actually offending commit. As 4.9 is EOL this fix will apply on all stable versions. Fixes: d853d145ea3e ("net: phy: add an option to disable EEE advertisement") Suggested-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/meson-gxl.c | 2 ++ 1 file changed, 2 insertions(+)