| Message ID | 92164896-38ff-4474-b98b-e83fc05b9509@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: improve and simplify EEE handling in phylib | expand |
On Sun, Feb 16, 2025 at 10:16:34PM +0100, Heiner Kallweit wrote: > If a mode is to be disabled, remove it from advertising_eee. > Disabling EEE modes shall be done before calling phy_start(), > warn if that's not the case. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Sun, Feb 16, 2025 at 10:16:34PM +0100, Heiner Kallweit wrote: > If a mode is to be disabled, remove it from advertising_eee. > Disabling EEE modes shall be done before calling phy_start(), > warn if that's not the case. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
diff --git a/include/linux/phy.h b/include/linux/phy.h index 481f8e21f..26a11a0c7 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1345,7 +1345,10 @@ static inline bool phy_is_started(struct phy_device *phydev) */ static inline void phy_disable_eee_mode(struct phy_device *phydev, u32 link_mode) { + WARN_ON(phy_is_started(phydev)); + linkmode_set_bit(link_mode, phydev->eee_disabled_modes); + linkmode_clear_bit(link_mode, phydev->advertising_eee); } void phy_resolve_aneg_pause(struct phy_device *phydev);
If a mode is to be disabled, remove it from advertising_eee. Disabling EEE modes shall be done before calling phy_start(), warn if that's not the case. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+)