| Message ID | 95dd5a0c-09ea-4847-94d9-b7aa3063e8ff@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c4e64095c00cb2de413cd6b90be047c273bcd491 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] r8169: enable EEE at 2.5G per default on RTL8125B | expand |
On Thu, Oct 17, 2024 at 10:27:44PM +0200, Heiner Kallweit wrote: > Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line > disables advertisement of EEE at 2.5G. Latest vendor driver r8125 > doesn't do this (any longer?), so this mode seems to be safe. > EEE saves quite some energy, therefore enable this mode per default. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Andrew Lunn <andrew@lunn.ch>: On Thu, 17 Oct 2024 22:27:44 +0200 you wrote: > Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line > disables advertisement of EEE at 2.5G. Latest vendor driver r8125 > doesn't do this (any longer?), so this mode seems to be safe. > EEE saves quite some energy, therefore enable this mode per default. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > [...] Here is the summary with links: - [net-next] r8169: enable EEE at 2.5G per default on RTL8125B https://git.kernel.org/netdev/net-next/c/c4e64095c00c You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c index cf29b1208..d504abba7 100644 --- a/drivers/net/ethernet/realtek/r8169_phy_config.c +++ b/drivers/net/ethernet/realtek/r8169_phy_config.c @@ -99,7 +99,6 @@ static void rtl8125a_config_eee_phy(struct phy_device *phydev) static void rtl8125b_config_eee_phy(struct phy_device *phydev) { - phy_modify_paged(phydev, 0xa6d, 0x12, 0x0001, 0x0000); phy_modify_paged(phydev, 0xa6d, 0x14, 0x0010, 0x0000); phy_modify_paged(phydev, 0xa42, 0x14, 0x0080, 0x0000); phy_modify_paged(phydev, 0xa4a, 0x11, 0x0200, 0x0000);
Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line disables advertisement of EEE at 2.5G. Latest vendor driver r8125 doesn't do this (any longer?), so this mode seems to be safe. EEE saves quite some energy, therefore enable this mode per default. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_phy_config.c | 1 - 1 file changed, 1 deletion(-)