| Message ID | 97d3ba83f5a2bfeb36f6bc0fb76724eb3dafb608.1707729403.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e58779f47e5eeb4fc9e3707951b81fbe31de5e3b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v3,net] selftests: net: cope with slow env in gro.sh test | expand |
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 12 Feb 2024 10:39:41 +0100 you wrote: > The gro self-tests sends the packets to be aggregated with > multiple write operations. > > When running is slow environment, it's hard to guarantee that > the GRO engine will wait for the last packet in an intended > train. > > [...] Here is the summary with links: - [v3,net] selftests: net: cope with slow env in gro.sh test https://git.kernel.org/netdev/net/c/e58779f47e5e You are awesome, thank you!
diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh index 19352f106c1d..02c21ff4ca81 100755 --- a/tools/testing/selftests/net/gro.sh +++ b/tools/testing/selftests/net/gro.sh @@ -31,6 +31,11 @@ run_test() { 1>>log.txt wait "${server_pid}" exit_code=$? + if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" && \ + ${exit_code} -ne 0 ]]; then + echo "Ignoring errors due to slow environment" 1>&2 + exit_code=0 + fi if [[ "${exit_code}" -eq 0 ]]; then break; fi
The gro self-tests sends the packets to be aggregated with multiple write operations. When running is slow environment, it's hard to guarantee that the GRO engine will wait for the last packet in an intended train. The above causes almost deterministic failures in our CI for the 'large' test-case. Address the issue explicitly ignoring failures for such case in slow environments (KSFT_MACHINE_SLOW==true). Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test") Reviewed-by: Willem de Bruijn <willemb@google.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- v2 -> v3: - dump the error suppression message only on actual errors (Jakub) v1 -> v2: - replace the '-a' operator with '&&' - Mattbe Note that the fixes tag is there mainly to justify targeting the net tree, and this is aiming at net to hopefully make the test more stable ASAP for both trees. --- tools/testing/selftests/net/gro.sh | 5 +++++ 1 file changed, 5 insertions(+)