| Message ID | 9903ebc67ba39368d7a1e93681c65305d868232c.1643972527.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 7881453e4adf497cf9109c84fa21eedda9ac6164 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | gro: a couple of minor optimization | expand |
On Fri, Feb 4, 2022 at 3:29 AM Paolo Abeni <pabeni@redhat.com> wrote: > > After commit 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb > carring sock reference") and commit af352460b465 ("net: fix GRO > skb truesize update") the truesize of the skb with stolen head is > properly updated by the GRO engine, we don't need anymore resetting > it at recycle time. > > v1 -> v2: > - clarify the commit message (Alexander) > > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- Reviewed-by: Eric Dumazet <edumazet@google.com>
diff --git a/net/core/gro.c b/net/core/gro.c index a11b286d1495..d43d42215bdb 100644 --- a/net/core/gro.c +++ b/net/core/gro.c @@ -634,7 +634,6 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb) skb->encapsulation = 0; skb_shinfo(skb)->gso_type = 0; - skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); if (unlikely(skb->slow_gro)) { skb_orphan(skb); skb_ext_reset(skb);
After commit 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb carring sock reference") and commit af352460b465 ("net: fix GRO skb truesize update") the truesize of the skb with stolen head is properly updated by the GRO engine, we don't need anymore resetting it at recycle time. v1 -> v2: - clarify the commit message (Alexander) Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- net/core/gro.c | 1 - 1 file changed, 1 deletion(-)