| Message ID | AM9PR04MB85066A2A4D7A2419C1CFC24CE2BD2@AM9PR04MB8506.eurprd04.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for Synopsis DWMAC IP on NXP Automotive SoCs | expand |
On 04/08/2024 22:49, Jan Petrous (OSS) wrote: > Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx > and S32R45 automotive series SoCs. > > Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
> From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, 5 August, 2024 7:10 > To: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com> > Cc: dl-S32 <S32@nxp.com>; linux-kernel@vger.kernel.org; linux-stm32@st- > md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; Claudiu > Manoil <claudiu.manoil@nxp.com>; netdev@vger.kernel.org > Subject: [EXT] Re: [PATCH 3/6] dt-bindings: net: Add DT bindings for DWMAC > on NXP S32G/R > > On 04/08/2024 22:49, Jan Petrous (OSS) wrote: > > Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx > > and S32R45 automotive series SoCs. > > > > Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. > </form letter> Does it mean that scripts/get_maintainer.pl doesn't care about devicetree ML? I just tried to recheck, but it still shows me the list I used originally: $ ll outgoing/*.patch -rw-rw-r-- 1 hop hop 1998 srp 4 11:33 outgoing/0000-cover-letter.patch -rw-rw-r-- 1 hop hop 2518 srp 4 11:33 outgoing/0001-net-driver-stmmac-extend-CSR-calc-support.patch -rw-rw-r-- 1 hop hop 2794 srp 4 11:33 outgoing/0002-net-stmmac-Expand-clock-rate-variables.patch -rw-rw-r-- 1 hop hop 4427 srp 4 11:33 outgoing/0003-dt-bindings-net-Add-DT-bindings-for-DWMAC-on-NXP-S32.patch -rw-rw-r-- 1 hop hop 8610 srp 4 11:33 outgoing/0004-net-stmmac-dwmac-s32cc-add-basic-NXP-S32G-S32R-glue-.patch -rw-rw-r-- 1 hop hop 1143 srp 4 11:33 outgoing/0005-MAINTAINERS-Add-Jan-Petrous-as-the-NXP-S32G-R-DWMAC-.patch -rw-rw-r-- 1 hop hop 1805 srp 4 11:33 outgoing/0006-net-stmmac-dwmac-s32cc-Read-PTP-clock-rate-when-read.patch $ ./scripts/get_maintainer.pl outgoing/*.patch Maxime Coquelin <mcoquelin.stm32@gmail.com> (maintainer:ARM/STM32 ARCHITECTURE) Alexandre Torgue <alexandre.torgue@foss.st.com> (maintainer:ARM/STM32 ARCHITECTURE) "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:46/46=100%,added_lines:61/61=100%,added_lines:69/69=100%,added_lines:165/165=100%,added_lines:298/298=100%,added_lines:35/35=100%,added_lines:51/51=100%) linux-kernel@vger.kernel.org (open list) linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE) linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE) Thanks. /Jan
On 05/08/2024 09:10, Jan Petrous (OSS) wrote: >> From: Krzysztof Kozlowski <krzk@kernel.org> >> Sent: Monday, 5 August, 2024 7:10 >> To: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>; Maxime Coquelin >> <mcoquelin.stm32@gmail.com>; Alexandre Torgue >> <alexandre.torgue@foss.st.com> >> Cc: dl-S32 <S32@nxp.com>; linux-kernel@vger.kernel.org; linux-stm32@st- >> md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; Claudiu >> Manoil <claudiu.manoil@nxp.com>; netdev@vger.kernel.org >> Subject: [EXT] Re: [PATCH 3/6] dt-bindings: net: Add DT bindings for DWMAC >> on NXP S32G/R >> >> On 04/08/2024 22:49, Jan Petrous (OSS) wrote: >>> Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx >>> and S32R45 automotive series SoCs. >>> >>> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> >> >> <form letter> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >> people, so fix your workflow. Tools might also fail if you work on some >> ancient tree (don't, instead use mainline) or work on fork of kernel >> (don't, instead use mainline). Just use b4 and everything should be >> fine, although remember about `b4 prep --auto-to-cc` if you added new >> patches to the patchset. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time. >> >> Please kindly resend and include all necessary To/Cc entries. >> </form letter> > > Does it mean that scripts/get_maintainer.pl doesn't care about devicetree ML? > I just tried to recheck, but it still shows me the list I used originally: It cares and always provides it. > > $ ll outgoing/*.patch > -rw-rw-r-- 1 hop hop 1998 srp 4 11:33 outgoing/0000-cover-letter.patch > -rw-rw-r-- 1 hop hop 2518 srp 4 11:33 outgoing/0001-net-driver-stmmac-extend-CSR-calc-support.patch > -rw-rw-r-- 1 hop hop 2794 srp 4 11:33 outgoing/0002-net-stmmac-Expand-clock-rate-variables.patch > -rw-rw-r-- 1 hop hop 4427 srp 4 11:33 outgoing/0003-dt-bindings-net-Add-DT-bindings-for-DWMAC-on-NXP-S32.patch > -rw-rw-r-- 1 hop hop 8610 srp 4 11:33 outgoing/0004-net-stmmac-dwmac-s32cc-add-basic-NXP-S32G-S32R-glue-.patch > -rw-rw-r-- 1 hop hop 1143 srp 4 11:33 outgoing/0005-MAINTAINERS-Add-Jan-Petrous-as-the-NXP-S32G-R-DWMAC-.patch > -rw-rw-r-- 1 hop hop 1805 srp 4 11:33 outgoing/0006-net-stmmac-dwmac-s32cc-Read-PTP-clock-rate-when-read.patch > $ ./scripts/get_maintainer.pl outgoing/*.patch > Maxime Coquelin <mcoquelin.stm32@gmail.com> (maintainer:ARM/STM32 ARCHITECTURE) > Alexandre Torgue <alexandre.torgue@foss.st.com> (maintainer:ARM/STM32 ARCHITECTURE) > "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:46/46=100%,added_lines:61/61=100%,added_lines:69/69=100%,added_lines:165/165=100%,added_lines:298/298=100%,added_lines:35/35=100%,added_lines:51/51=100%) > linux-kernel@vger.kernel.org (open list) > linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 ARCHITECTURE) > linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 ARCHITECTURE) Read the form letter carefully. There are several instructions mentioned. Above commands look sensible but if it still does not work for you, then I suspect you develop on some old, vendor tree. BTW, none of other patches made to the list or your threading is completely broken. See: https://lore.kernel.org/all/AM9PR04MB85066A2A4D7A2419C1CFC24CE2BD2@AM9PR04MB8506.eurprd04.prod.outlook.com/ Best regards, Krzysztof
> From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, 5 August, 2024 9:17 > To: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; Alexandre Torgue > <alexandre.torgue@foss.st.com> > Cc: dl-S32 <S32@nxp.com>; linux-kernel@vger.kernel.org; linux-stm32@st- > md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; Claudiu > Manoil <claudiu.manoil@nxp.com>; netdev@vger.kernel.org > Subject: Re: [EXT] Re: [PATCH 3/6] dt-bindings: net: Add DT bindings for > DWMAC on NXP S32G/R > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 05/08/2024 09:10, Jan Petrous (OSS) wrote: > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: Monday, 5 August, 2024 7:10 > >> To: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>; Maxime Coquelin > >> <mcoquelin.stm32@gmail.com>; Alexandre Torgue > >> <alexandre.torgue@foss.st.com> > >> Cc: dl-S32 <S32@nxp.com>; linux-kernel@vger.kernel.org; linux-stm32@st- > >> md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; > Claudiu > >> Manoil <claudiu.manoil@nxp.com>; netdev@vger.kernel.org > >> Subject: [EXT] Re: [PATCH 3/6] dt-bindings: net: Add DT bindings for > DWMAC > >> on NXP S32G/R > >> > >> On 04/08/2024 22:49, Jan Petrous (OSS) wrote: > >>> Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx > >>> and S32R45 automotive series SoCs. > >>> > >>> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> > >> > >> <form letter> > >> Please use scripts/get_maintainers.pl to get a list of necessary people > >> and lists to CC. It might happen, that command when run on an older > >> kernel, gives you outdated entries. Therefore please be sure you base > >> your patches on recent Linux kernel. > >> > >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of > >> people, so fix your workflow. Tools might also fail if you work on some > >> ancient tree (don't, instead use mainline) or work on fork of kernel > >> (don't, instead use mainline). Just use b4 and everything should be > >> fine, although remember about `b4 prep --auto-to-cc` if you added new > >> patches to the patchset. > >> > >> You missed at least devicetree list (maybe more), so this won't be > >> tested by automated tooling. Performing review on untested code might be > >> a waste of time. > >> > >> Please kindly resend and include all necessary To/Cc entries. > >> </form letter> > > > > Does it mean that scripts/get_maintainer.pl doesn't care about devicetree > ML? > > I just tried to recheck, but it still shows me the list I used originally: > > It cares and always provides it. > > > > > $ ll outgoing/*.patch > > -rw-rw-r-- 1 hop hop 1998 srp 4 11:33 outgoing/0000-cover-letter.patch > > -rw-rw-r-- 1 hop hop 2518 srp 4 11:33 outgoing/0001-net-driver-stmmac- > extend-CSR-calc-support.patch > > -rw-rw-r-- 1 hop hop 2794 srp 4 11:33 outgoing/0002-net-stmmac-Expand- > clock-rate-variables.patch > > -rw-rw-r-- 1 hop hop 4427 srp 4 11:33 outgoing/0003-dt-bindings-net-Add- > DT-bindings-for-DWMAC-on-NXP-S32.patch > > -rw-rw-r-- 1 hop hop 8610 srp 4 11:33 outgoing/0004-net-stmmac-dwmac- > s32cc-add-basic-NXP-S32G-S32R-glue-.patch > > -rw-rw-r-- 1 hop hop 1143 srp 4 11:33 outgoing/0005-MAINTAINERS-Add- > Jan-Petrous-as-the-NXP-S32G-R-DWMAC-.patch > > -rw-rw-r-- 1 hop hop 1805 srp 4 11:33 outgoing/0006-net-stmmac-dwmac- > s32cc-Read-PTP-clock-rate-when-read.patch > > $ ./scripts/get_maintainer.pl outgoing/*.patch > > Maxime Coquelin <mcoquelin.stm32@gmail.com> (maintainer:ARM/STM32 > ARCHITECTURE) > > Alexandre Torgue <alexandre.torgue@foss.st.com> > (maintainer:ARM/STM32 ARCHITECTURE) > > "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com> > (commit_signer:1/1=100%,authored:1/1=100%,added_lines:46/46=100%,add > ed_lines:61/61=100%,added_lines:69/69=100%,added_lines:165/165=100%,a > dded_lines:298/298=100%,added_lines:35/35=100%,added_lines:51/51=100 > %) > > linux-kernel@vger.kernel.org (open list) > > linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32 > ARCHITECTURE) > > linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32 > ARCHITECTURE) > > Read the form letter carefully. There are several instructions > mentioned. Above commands look sensible but if it still does not work > for you, then I suspect you develop on some old, vendor tree. > Thanks. Of course it was on my side, sorry. I will resend v2 with wider audience. /Jan
diff --git a/Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml new file mode 100644 index 000000000000..443ad918a9a5 --- /dev/null +++ b/Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml @@ -0,0 +1,127 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2021-2024 NXP +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/nxp,s32cc-dwmac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP S32G2xx/S32G3xx/S32R45 GMAC ethernet controller + +maintainers: + - Jan Petrous (OSS) <jan.petrous@oss.nxp.com> + +description: | + This device is a platform glue layer for stmmac. + Please see snps,dwmac.yaml for the other unchanged properties. + +properties: + compatible: + enum: + - nxp,s32g2-dwmac + - nxp,s32g3-dwmac + - nxp,s32r45-dwmac + + reg: + items: + - description: Main GMAC registers + - description: GMAC PHY mode control register + + interrupts: + description: Common GMAC interrupt + + interrupt-names: + const: macirq + + clocks: + items: + - description: Main GMAC clock + - description: Transmit clock + - description: Receive clock + - description: PTP reference clock + + clock-names: + items: + - const: stmmaceth + - const: tx + - const: rx + - const: ptp_ref + +required: + - compatible + - reg + - interrupts + - interrupt-names + - clocks + - clock-names + - phy-mode + +allOf: + - $ref: snps,dwmac.yaml# + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/phy/phy.h> + bus { + #address-cells = <2>; + #size-cells = <2>; + + ethernet@4033c000 { + compatible = "nxp,s32cc-dwmac"; + reg = <0x0 0x4033c000 0x0 0x2000>, /* gmac IP */ + <0x0 0x4007c004 0x0 0x4>; /* GMAC_0_CTRL_STS */ + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "macirq"; + snps,mtl-rx-config = <&mtl_rx_setup>; + snps,mtl-tx-config = <&mtl_tx_setup>; + clocks = <&clks 24>, <&clks 17>, <&clks 16>, <&clks 15>; + clock-names = "stmmaceth", "tx", "rx", "ptp_ref"; + phy-mode = "rgmii-id"; + phy-handle = <&phy0>; + + mtl_rx_setup: rx-queues-config { + snps,rx-queues-to-use = <5>; + + queue0 { + }; + queue1 { + }; + queue2 { + }; + queue3 { + }; + queue4 { + }; + }; + + mtl_tx_setup: tx-queues-config { + snps,tx-queues-to-use = <5>; + + queue0 { + }; + queue1 { + }; + queue2 { + }; + queue3 { + }; + queue4 { + }; + }; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + + phy0: ethernet-phy@0 { + reg = <0>; + }; + + }; + }; + }; diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 3eb65e63fdae..3311438f67ee 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -66,6 +66,7 @@ properties: - ingenic,x2000-mac - loongson,ls2k-dwmac - loongson,ls7a-dwmac + - nxp,s32cc-dwmac - qcom,qcs404-ethqos - qcom,sa8775p-ethqos - qcom,sc8280xp-ethqos
Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx and S32R45 automotive series SoCs. Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com> --- .../bindings/net/nxp,s32cc-dwmac.yaml | 127 ++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml | 1 + 2 files changed, 128 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml