| Message ID | E1mpSbK-00BXoo-UE@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phylink: introduce legacy mode flag | expand |
On Tue, Nov 23, 2021 at 10:00:34AM +0000, Russell King (Oracle) wrote: > ag71xx has a PCS, but does not make use of the phylink PCS support. > Mark it was a pre-March 2020 driver. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Hi, I've just been looking closer at this driver, and it seems that we can drop the "legacy_pre_march2020" flag, and in doing so, delete the ag71xx_mac_pcs_get_state and ag71xx_mac_an_restart functions entirely, removing them from ag71xx_phylink_mac_ops. Should this driver need to deal with the PCS - in other words, to modify the advertisement, then it will need to make use of the phylink_pcs support. I'll send a v2 in a day or two. Thanks!
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index ff924f06581e..89b6a8bfee43 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -1111,6 +1111,7 @@ static int ag71xx_phylink_setup(struct ag71xx *ag) ag->phylink_config.dev = &ag->ndev->dev; ag->phylink_config.type = PHYLINK_NETDEV; + ag->phylink_config.legacy_pre_march2020 = true; ag->phylink_config.mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD;
ag71xx has a PCS, but does not make use of the phylink PCS support. Mark it was a pre-March 2020 driver. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/atheros/ag71xx.c | 1 + 1 file changed, 1 insertion(+)