| Message ID | E1rhosE-003yuc-FM@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 84c49aac0ea4df7ab69d4f0f2ce62dc9b1e77363 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode | expand |
On Wed, Mar 06, 2024 at 10:51:46AM +0000, Russell King (Oracle) wrote: > Update the Marvell 88e6185 PCS driver to use neg_mode rather than the > mode argument to match the other updated PCS drivers. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 3/6/24 02:51, Russell King (Oracle) wrote: > Update the Marvell 88e6185 PCS driver to use neg_mode rather than the > mode argument to match the other updated PCS drivers. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 06 Mar 2024 10:51:46 +0000 you wrote: > Update the Marvell 88e6185 PCS driver to use neg_mode rather than the > mode argument to match the other updated PCS drivers. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > drivers/net/dsa/mv88e6xxx/pcs-6185.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next] net: dsa: mv88e6xxx: update 88e6185 PCS driver to use neg_mode https://git.kernel.org/netdev/net-next/c/84c49aac0ea4 You are awesome, thank you!
diff --git a/drivers/net/dsa/mv88e6xxx/pcs-6185.c b/drivers/net/dsa/mv88e6xxx/pcs-6185.c index 4d677f836807..5a27d047a38e 100644 --- a/drivers/net/dsa/mv88e6xxx/pcs-6185.c +++ b/drivers/net/dsa/mv88e6xxx/pcs-6185.c @@ -95,7 +95,7 @@ static void mv88e6185_pcs_get_state(struct phylink_pcs *pcs, } } -static int mv88e6185_pcs_config(struct phylink_pcs *pcs, unsigned int mode, +static int mv88e6185_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode, phy_interface_t interface, const unsigned long *advertising, bool permit_pause_to_mac) @@ -137,6 +137,7 @@ static int mv88e6185_pcs_init(struct mv88e6xxx_chip *chip, int port) mpcs->chip = chip; mpcs->port = port; mpcs->phylink_pcs.ops = &mv88e6185_phylink_pcs_ops; + mpcs->phylink_pcs.neg_mode = true; irq = mv88e6xxx_serdes_irq_mapping(chip, port); if (irq) {
Update the Marvell 88e6185 PCS driver to use neg_mode rather than the mode argument to match the other updated PCS drivers. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/dsa/mv88e6xxx/pcs-6185.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)