| Message ID | E1s0OGx-009hgr-NP@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e47e5e85da3abfc68b3e2f574285234b3fff6fc0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: prestera: use phylink_pcs_change() to report PCS link change events | expand |
On Fri, Apr 26, 2024 at 05:18:03PM +0100, Russell King (Oracle) wrote: > Use phylink_pcs_change() when reporting changes in PCS link state to > phylink as the interrupts are informing us about changes to the PCS > state. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 26 Apr 2024 17:18:03 +0100 you wrote: > Use phylink_pcs_change() when reporting changes in PCS link state to > phylink as the interrupts are informing us about changes to the PCS > state. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next] net: prestera: use phylink_pcs_change() to report PCS link change events https://git.kernel.org/netdev/net-next/c/e47e5e85da3a You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 4fb886c57cd7..ba6d53ac7f55 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -821,7 +821,7 @@ static void prestera_port_handle_event(struct prestera_switch *sw, if (port->state_mac.oper) { if (port->phy_link) - phylink_mac_change(port->phy_link, true); + phylink_pcs_change(&port->phylink_pcs, true); else netif_carrier_on(port->dev); @@ -829,7 +829,7 @@ static void prestera_port_handle_event(struct prestera_switch *sw, queue_delayed_work(prestera_wq, caching_dw, 0); } else { if (port->phy_link) - phylink_mac_change(port->phy_link, false); + phylink_pcs_change(&port->phylink_pcs, false); else if (netif_running(port->dev) && netif_carrier_ok(port->dev)) netif_carrier_off(port->dev);
Use phylink_pcs_change() when reporting changes in PCS link state to phylink as the interrupts are informing us about changes to the PCS state. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)