| Message ID | ZGKGwtsobVZecWa4@work (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fe6559fab328972a2c8687d322fa54ab6d08f209 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next] net: libwx: Replace zero-length array with flexible-array member | expand |
On Mon, May 15, 2023 at 01:23:46PM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays as fake flexible arrays are deprecated, and we are > moving towards adopting C99 flexible-array members instead. > > Transform zero-length array into flexible-array member in struct > wx_q_vector. > > Link: https://github.com/KSPP/linux/issues/21 > Link: https://github.com/KSPP/linux/issues/286 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On Mon, May 15, 2023 at 01:23:46PM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays as fake flexible arrays are deprecated, and we are > moving towards adopting C99 flexible-array members instead. > > Transform zero-length array into flexible-array member in struct > wx_q_vector. > > Link: https://github.com/KSPP/linux/issues/21 > Link: https://github.com/KSPP/linux/issues/286 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 15 May 2023 13:23:46 -0600 you wrote: > Zero-length arrays as fake flexible arrays are deprecated, and we are > moving towards adopting C99 flexible-array members instead. > > Transform zero-length array into flexible-array member in struct > wx_q_vector. > > Link: https://github.com/KSPP/linux/issues/21 > Link: https://github.com/KSPP/linux/issues/286 > Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > > [...] Here is the summary with links: - [next] net: libwx: Replace zero-length array with flexible-array member https://git.kernel.org/netdev/net-next/c/fe6559fab328 You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h index 32f952d93009..cbe7f184b50e 100644 --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h @@ -598,7 +598,7 @@ struct wx_q_vector { char name[IFNAMSIZ + 17]; /* for dynamic allocation of rings associated with this q_vector */ - struct wx_ring ring[0] ____cacheline_internodealigned_in_smp; + struct wx_ring ring[] ____cacheline_internodealigned_in_smp; }; enum wx_isb_idx {
Zero-length arrays as fake flexible arrays are deprecated, and we are moving towards adopting C99 flexible-array members instead. Transform zero-length array into flexible-array member in struct wx_q_vector. Link: https://github.com/KSPP/linux/issues/21 Link: https://github.com/KSPP/linux/issues/286 Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/ethernet/wangxun/libwx/wx_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)