| Message ID | ZIlmX/ClDXwxQncL@kadam (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 97c5209b3d374a25ebdb4c2ea9e9c1b121768da0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next,resend] leds: trigger: netdev: uninitialized variable in netdev_trig_activate() | expand |
On Wed, 14 Jun 2023, Dan Carpenter wrote: > The qca8k_cled_hw_control_get() function which implements ->hw_control_get > sets the appropriate bits but does not clear them. This leads to an > uninitialized variable bug. Fix this by setting mode to zero at the > start. > > Fixes: e0256648c831 ("net: dsa: qca8k: implement hw_control ops") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > Resending because this actually goes through net-next and not the led > subsystem. > > v2: In the original patch I fixed qca8k_cled_hw_control_get() instead > so that patch went to netdev instead of to the led subsystem. > https://lore.kernel.org/all/5dff3719-f827-45b6-a0d3-a00efed1099b@moroto.mountain/ > Fixing it here is a more reliable way to do it. > > drivers/leds/trigger/ledtrig-netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Lee Jones <lee@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Wed, 14 Jun 2023 10:03:59 +0300 you wrote: > The qca8k_cled_hw_control_get() function which implements ->hw_control_get > sets the appropriate bits but does not clear them. This leads to an > uninitialized variable bug. Fix this by setting mode to zero at the > start. > > Fixes: e0256648c831 ("net: dsa: qca8k: implement hw_control ops") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > [...] Here is the summary with links: - [v2,net-next,resend] leds: trigger: netdev: uninitialized variable in netdev_trig_activate() https://git.kernel.org/netdev/net-next/c/97c5209b3d37 You are awesome, thank you!
diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c index b0a6f2749552..2311dae7f070 100644 --- a/drivers/leds/trigger/ledtrig-netdev.c +++ b/drivers/leds/trigger/ledtrig-netdev.c @@ -445,7 +445,7 @@ static void netdev_trig_work(struct work_struct *work) static int netdev_trig_activate(struct led_classdev *led_cdev) { struct led_netdev_data *trigger_data; - unsigned long mode; + unsigned long mode = 0; struct device *dev; int rc;
The qca8k_cled_hw_control_get() function which implements ->hw_control_get sets the appropriate bits but does not clear them. This leads to an uninitialized variable bug. Fix this by setting mode to zero at the start. Fixes: e0256648c831 ("net: dsa: qca8k: implement hw_control ops") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- Resending because this actually goes through net-next and not the led subsystem. v2: In the original patch I fixed qca8k_cled_hw_control_get() instead so that patch went to netdev instead of to the led subsystem. https://lore.kernel.org/all/5dff3719-f827-45b6-a0d3-a00efed1099b@moroto.mountain/ Fixing it here is a more reliable way to do it. drivers/leds/trigger/ledtrig-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)