| Message ID | a026153108dd21239036a032b95c25b5cece253b.1655153616.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d7dd6eccfbc95ac47a12396f84e7e1b361db654b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: bgmac: Fix an erroneous kfree() in bgmac_remove() | expand |
On 6/13/22 13:53, Christophe JAILLET wrote: > 'bgmac' is part of a managed resource allocated with bgmac_alloc(). It > should not be freed explicitly. > > Remove the erroneous kfree() from the .remove() function. > > Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it" > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 13 Jun 2022 22:53:50 +0200 you wrote: > 'bgmac' is part of a managed resource allocated with bgmac_alloc(). It > should not be freed explicitly. > > Remove the erroneous kfree() from the .remove() function. > > Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it" > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > [...] Here is the summary with links: - net: bgmac: Fix an erroneous kfree() in bgmac_remove() https://git.kernel.org/netdev/net/c/d7dd6eccfbc9 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c index e6f48786949c..02bd3cf9a260 100644 --- a/drivers/net/ethernet/broadcom/bgmac-bcma.c +++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c @@ -332,7 +332,6 @@ static void bgmac_remove(struct bcma_device *core) bcma_mdio_mii_unregister(bgmac->mii_bus); bgmac_enet_remove(bgmac); bcma_set_drvdata(core, NULL); - kfree(bgmac); } static struct bcma_driver bgmac_bcma_driver = {
'bgmac' is part of a managed resource allocated with bgmac_alloc(). It should not be freed explicitly. Remove the erroneous kfree() from the .remove() function. Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it" Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/broadcom/bgmac-bcma.c | 1 - 1 file changed, 1 deletion(-)