| Message ID | a1cf8a6ccca511e948075c4e20eea2e2ba001c2c.1633090323.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 63b1bae940a9c93232b9e7b0eb5b1e125303f893 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: renesas,ether: Update example to match reality | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hi Geert, Thanks for your patch. On 2021-10-01 14:13:20 +0200, Geert Uytterhoeven wrote: > - Drop unneeded interrupt-parent, > - Convert to new style CPG/MSSR bindings, > - Add missing power-domains and resets properties, > - Update PHY subnode: > - Add example compatible values, > - Add micrel,led-mode and reset-gpios examples. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > .../devicetree/bindings/net/renesas,ether.yaml | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml > index c101a1ec846ea8e9..06b38c9bc6ec38e4 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml > +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml > @@ -100,15 +100,18 @@ additionalProperties: false > examples: > # Lager board > - | > - #include <dt-bindings/clock/r8a7790-clock.h> > - #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/clock/r8a7790-cpg-mssr.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/r8a7790-sysc.h> > + #include <dt-bindings/gpio/gpio.h> > > ethernet@ee700000 { > compatible = "renesas,ether-r8a7790", "renesas,rcar-gen2-ether"; > reg = <0xee700000 0x400>; > - interrupt-parent = <&gic>; > - interrupts = <0 162 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&mstp8_clks R8A7790_CLK_ETHER>; > + interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 813>; > + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; > + resets = <&cpg 813>; > phy-mode = "rmii"; > phy-handle = <&phy1>; > renesas,ether-link-active-low; > @@ -116,8 +119,12 @@ examples: > #size-cells = <0>; > > phy1: ethernet-phy@1 { > + compatible = "ethernet-phy-id0022.1537", > + "ethernet-phy-ieee802.3-c22"; > reg = <1>; > interrupt-parent = <&irqc0>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + micrel,led-mode = <1>; > + reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; > }; > }; > -- > 2.25.1 >
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 1 Oct 2021 14:13:20 +0200 you wrote: > - Drop unneeded interrupt-parent, > - Convert to new style CPG/MSSR bindings, > - Add missing power-domains and resets properties, > - Update PHY subnode: > - Add example compatible values, > - Add micrel,led-mode and reset-gpios examples. > > [...] Here is the summary with links: - dt-bindings: net: renesas,ether: Update example to match reality https://git.kernel.org/netdev/net-next/c/63b1bae940a9 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/Documentation/devicetree/bindings/net/renesas,ether.yaml b/Documentation/devicetree/bindings/net/renesas,ether.yaml index c101a1ec846ea8e9..06b38c9bc6ec38e4 100644 --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml @@ -100,15 +100,18 @@ additionalProperties: false examples: # Lager board - | - #include <dt-bindings/clock/r8a7790-clock.h> - #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/clock/r8a7790-cpg-mssr.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/power/r8a7790-sysc.h> + #include <dt-bindings/gpio/gpio.h> ethernet@ee700000 { compatible = "renesas,ether-r8a7790", "renesas,rcar-gen2-ether"; reg = <0xee700000 0x400>; - interrupt-parent = <&gic>; - interrupts = <0 162 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&mstp8_clks R8A7790_CLK_ETHER>; + interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 813>; + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; + resets = <&cpg 813>; phy-mode = "rmii"; phy-handle = <&phy1>; renesas,ether-link-active-low; @@ -116,8 +119,12 @@ examples: #size-cells = <0>; phy1: ethernet-phy@1 { + compatible = "ethernet-phy-id0022.1537", + "ethernet-phy-ieee802.3-c22"; reg = <1>; interrupt-parent = <&irqc0>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + micrel,led-mode = <1>; + reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; }; };
- Drop unneeded interrupt-parent, - Convert to new style CPG/MSSR bindings, - Add missing power-domains and resets properties, - Update PHY subnode: - Add example compatible values, - Add micrel,led-mode and reset-gpios examples. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- .../devicetree/bindings/net/renesas,ether.yaml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)