Message ID | a4b3c8c1cca9515e67adac83af5ba1b1fab2fcbc.1727169288.git.geert+renesas@glider.be (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP | expand |
Context | Check | Description |
---|---|---|
netdev/tree_selection | success | Series ignored based on subject |
Am Dienstag, 24. September 2024, 11:15:31 CEST schrieb Geert Uytterhoeven: > The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence > add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this > driver when configuring a kernel without Rockchip platform support. > > Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> makes a lot of sense, and with the compile-test in, it'll still get test-build Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/net/can/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig > index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644 > --- a/drivers/net/can/rockchip/Kconfig > +++ b/drivers/net/can/rockchip/Kconfig > @@ -3,6 +3,7 @@ > config CAN_ROCKCHIP_CANFD > tristate "Rockchip CAN-FD controller" > depends on OF || COMPILE_TEST > + depends on ARCH_ROCKCHIP || COMPILE_TEST > select CAN_RX_OFFLOAD > help > Say Y here if you want to use CAN-FD controller found on >
On 24.09.2024 11:15:31, Geert Uytterhoeven wrote: > The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence > add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this > driver when configuring a kernel without Rockchip platform support. > > Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied to linux-can/testing. Thanks, Marc
diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644 --- a/drivers/net/can/rockchip/Kconfig +++ b/drivers/net/can/rockchip/Kconfig @@ -3,6 +3,7 @@ config CAN_ROCKCHIP_CANFD tristate "Rockchip CAN-FD controller" depends on OF || COMPILE_TEST + depends on ARCH_ROCKCHIP || COMPILE_TEST select CAN_RX_OFFLOAD help Say Y here if you want to use CAN-FD controller found on
The Rockchip CAN-FD controller is only present on Rockchip SoCs. Hence add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this driver when configuring a kernel without Rockchip platform support. Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/net/can/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+)