[net-next,v1] vsock/loopback: don't disable irqs for queue access

Commit Message

Arseniy Krasnov April 13, 2023, 9:17 a.m. UTC

This replaces 'skb_queue_tail()' with 'virtio_vsock_skb_queue_tail()'.
The first one uses 'spin_lock_irqsave()', second uses 'spin_lock_bh()'.
There is no need to disable interrupts in the loopback transport as
there is no access to the queue with skbs from interrupt context. Both
virtio and vhost transports work in the same way.

Signed-off-by: Arseniy Krasnov <[e-mail]>
Reviewed-by: Stefano Garzarella <[e-mail]>
---
 net/vmw_vsock/vsock_loopback.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

[e-mail] April 14, 2023, 10:10 a.m. UTC | #1

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Thu, 13 Apr 2023 12:17:19 +0300 you wrote:
> This replaces 'skb_queue_tail()' with 'virtio_vsock_skb_queue_tail()'.
> The first one uses 'spin_lock_irqsave()', second uses 'spin_lock_bh()'.
> There is no need to disable interrupts in the loopback transport as
> there is no access to the queue with skbs from interrupt context. Both
> virtio and vhost transports work in the same way.
> 
> Signed-off-by: Arseniy Krasnov <[e-mail]>
> Reviewed-by: Stefano Garzarella <[e-mail]>
> 
> [...]

Here is the summary with links:
  - [net-next,v1] vsock/loopback: don't disable irqs for queue access
    https://git.kernel.org/netdev/net-next/c/eaaa4e923979

You are awesome, thank you!

Patch

diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c
index e3afc0c866f5..5c6360df1f31 100644
--- a/net/vmw_vsock/vsock_loopback.c
+++ b/net/vmw_vsock/vsock_loopback.c
@@ -31,8 +31,7 @@  static int vsock_loopback_send_pkt(struct sk_buff *skb)
 	struct vsock_loopback *vsock = &the_vsock_loopback;
 	int len = skb->len;
 
-	skb_queue_tail(&vsock->pkt_queue, skb);
-
+	virtio_vsock_skb_queue_tail(&vsock->pkt_queue, skb);
 	queue_work(vsock->workqueue, &vsock->pkt_work);
 
 	return len;