| Message ID | ab963584b0a7e3b4dac39472a4b82ca264d79630.1726580902.git.daniel@makrotopia.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d2b366c43443a21d9bcf047f3ee1f09cf9792dc4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,1/2] net: phy: aquantia: fix setting active_low bit | expand |
On Tue, Sep 17, 2024 at 02:49:40PM +0100, Daniel Golle wrote: > phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting > in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit. > Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit. > > Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs") > Signed-off-by: Daniel Golle <daniel@makrotopia.org> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 17 Sep 2024 14:49:40 +0100 you wrote: > phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting > in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit. > Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit. > > Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs") > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > > [...] Here is the summary with links: - [net,1/2] net: phy: aquantia: fix setting active_low bit https://git.kernel.org/netdev/net/c/d2b366c43443 - [net,2/2] net: phy: aquantia: fix applying active_low bit after reset https://git.kernel.org/netdev/net/c/6f9defaf9912 You are awesome, thank you!
diff --git a/drivers/net/phy/aquantia/aquantia_leds.c b/drivers/net/phy/aquantia/aquantia_leds.c index 0516ac02c3f81..201c8df93fad9 100644 --- a/drivers/net/phy/aquantia/aquantia_leds.c +++ b/drivers/net/phy/aquantia/aquantia_leds.c @@ -120,7 +120,8 @@ int aqr_phy_led_hw_control_set(struct phy_device *phydev, u8 index, int aqr_phy_led_active_low_set(struct phy_device *phydev, int index, bool enable) { return phy_modify_mmd(phydev, MDIO_MMD_VEND1, AQR_LED_DRIVE(index), - VEND1_GLOBAL_LED_DRIVE_VDD, enable); + VEND1_GLOBAL_LED_DRIVE_VDD, + enable ? VEND1_GLOBAL_LED_DRIVE_VDD : 0); } int aqr_phy_led_polarity_set(struct phy_device *phydev, int index, unsigned long modes)
phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit. Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit. Fixes: 61578f679378 ("net: phy: aquantia: add support for PHY LEDs") Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- drivers/net/phy/aquantia/aquantia_leds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)