| Message ID | ac622d4a-ae0a-3817-710f-849db4015c78@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 42666b2c452ce87894786aae05e3fad3cfc6cb59 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] r8169: disable detection of chip version 36 | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 9 Sep 2022 08:00:22 +0200 you wrote: > I found no evidence that this chip version ever made it to the mass > market. Therefore disable detection. Like in similar cases before: > If nobody complains, we'll remove support for this chip version after > few months. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > [...] Here is the summary with links: - [net-next] r8169: disable detection of chip version 36 https://git.kernel.org/netdev/net-next/c/42666b2c452c You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 1d571af4d..8e1dae4de 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -1998,7 +1998,10 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii) /* 8168F family. */ { 0x7c8, 0x488, RTL_GIGA_MAC_VER_38 }, - { 0x7cf, 0x481, RTL_GIGA_MAC_VER_36 }, + /* It seems this chip version never made it to + * the wild. Let's disable detection. + * { 0x7cf, 0x481, RTL_GIGA_MAC_VER_36 }, + */ { 0x7cf, 0x480, RTL_GIGA_MAC_VER_35 }, /* 8168E family. */
I found no evidence that this chip version ever made it to the mass market. Therefore disable detection. Like in similar cases before: If nobody complains, we'll remove support for this chip version after few months. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)