Message ID | b0832102-28ab-4223-b879-91fb1fc11278@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 3bf8163a36adb550536c0de8ae00685f050edf53 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next] net: phy: c45: don't use temporary linkmode bitmaps in genphy_c45_ethtool_get_eee | expand |
On Tue, Nov 12, 2024 at 09:33:11PM +0100, Heiner Kallweit wrote: > genphy_c45_eee_is_active() populates both bitmaps only if it returns > successfully. So we can avoid the overhead of the temporary bitmaps. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Thanks!
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 12 Nov 2024 21:33:11 +0100 you wrote: > genphy_c45_eee_is_active() populates both bitmaps only if it returns > successfully. So we can avoid the overhead of the temporary bitmaps. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/phy/phy-c45.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Here is the summary with links: - [net-next] net: phy: c45: don't use temporary linkmode bitmaps in genphy_c45_ethtool_get_eee https://git.kernel.org/netdev/net-next/c/3bf8163a36ad You are awesome, thank you!
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 29cc22a4b..96a51a0b2 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -1521,20 +1521,17 @@ EXPORT_SYMBOL(genphy_c45_eee_is_active); int genphy_c45_ethtool_get_eee(struct phy_device *phydev, struct ethtool_keee *data) { - __ETHTOOL_DECLARE_LINK_MODE_MASK(adv) = {}; - __ETHTOOL_DECLARE_LINK_MODE_MASK(lp) = {}; bool is_enabled; int ret; - ret = genphy_c45_eee_is_active(phydev, adv, lp, &is_enabled); + ret = genphy_c45_eee_is_active(phydev, data->advertised, + data->lp_advertised, &is_enabled); if (ret < 0) return ret; data->eee_enabled = is_enabled; data->eee_active = ret; linkmode_copy(data->supported, phydev->supported_eee); - linkmode_copy(data->advertised, adv); - linkmode_copy(data->lp_advertised, lp); return 0; }
genphy_c45_eee_is_active() populates both bitmaps only if it returns successfully. So we can avoid the overhead of the temporary bitmaps. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/phy-c45.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)