| Message ID | ca7ea96d62a26732f0491153c3979dc1c0d8d34a.1668526793.git.lucien.xin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b78c4162823dddc621649edae704b14c5973298c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h | expand |
On 15 Nov 10:39, Xin Long wrote: >Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is >included in quite some places in netfilter and openswitch and >net/sched. It's not necessary to include "net/sctp/sctp.h" if >a module does not have dependence on SCTP, "linux/sctp.h" is >the right one to include. > >Signed-off-by: Xin Long <lucien.xin@gmail.com> LGTM as long as it builds: Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 15 Nov 2022 10:39:53 -0500 you wrote: > Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is > included in quite some places in netfilter and openswitch and > net/sched. It's not necessary to include "net/sctp/sctp.h" if > a module does not have dependence on SCTP, "linux/sctp.h" is > the right one to include. > > Signed-off-by: Xin Long <lucien.xin@gmail.com> > > [...] Here is the summary with links: - [net-next] sctp: change to include linux/sctp.h in net/sctp/checksum.h https://git.kernel.org/netdev/net-next/c/b78c4162823d You are awesome, thank you!
diff --git a/include/net/sctp/checksum.h b/include/net/sctp/checksum.h index 5a9bb09f32b6..f514a0aa849e 100644 --- a/include/net/sctp/checksum.h +++ b/include/net/sctp/checksum.h @@ -24,7 +24,7 @@ #define __sctp_checksum_h__ #include <linux/types.h> -#include <net/sctp/sctp.h> +#include <linux/sctp.h> #include <linux/crc32c.h> #include <linux/crc32.h>
Currently "net/sctp/checksum.h" including "net/sctp/sctp.h" is included in quite some places in netfilter and openswitch and net/sched. It's not necessary to include "net/sctp/sctp.h" if a module does not have dependence on SCTP, "linux/sctp.h" is the right one to include. Signed-off-by: Xin Long <lucien.xin@gmail.com> --- include/net/sctp/checksum.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)