| Message ID | d82489be8ed911c383c3447e9abf469995ccf39a.1682496488.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9b78d919632b7149d311aaad5a977e4b48b10321 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] net: phy: hide the PHYLIB_LEDS knob | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Wed, 26 Apr 2023 10:15:31 +0200 you wrote: > commit 4bb7aac70b5d ("net: phy: fix circular LEDS_CLASS dependencies") > solved a build failure, but introduces a new config knob with a default > 'y' value: PHYLIB_LEDS. > > The latter is against the current new config policy. The exception > was raised to allow the user to catch bad configurations without led > support. > > [...] Here is the summary with links: - [v2,net-next] net: phy: hide the PHYLIB_LEDS knob https://git.kernel.org/netdev/net-next/c/9b78d919632b You are awesome, thank you!
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 2f3ddc446cbb..93b8efc79227 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -45,10 +45,8 @@ config LED_TRIGGER_PHY for any speed known to the PHY. config PHYLIB_LEDS - bool "Support probing LEDs from device tree" + def_bool OF depends on LEDS_CLASS=y || LEDS_CLASS=PHYLIB - depends on OF - default y help When LED class support is enabled, phylib can automatically probe LED setting from device tree.
commit 4bb7aac70b5d ("net: phy: fix circular LEDS_CLASS dependencies") solved a build failure, but introduces a new config knob with a default 'y' value: PHYLIB_LEDS. The latter is against the current new config policy. The exception was raised to allow the user to catch bad configurations without led support. Anyway the current definition of PHYLIB_LEDS does not fit the above goal: if LEDS_CLASS is disabled, the new config will be available only with PHYLIB disabled, too. Hide the mentioned config, to preserve the randconfig testing done so far, while respecting the mentioned policy. Suggested-by: Andrew Lunn <andrew@lunn.ch> Suggested-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- v1 -> v2: - hide the knob instead of drop + IS_REACHABLE() --- drivers/net/phy/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)