From patchwork Wed Apr 26 08:15:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Abeni X-Patchwork-Id: 13224224 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04D5C7618E for ; Wed, 26 Apr 2023 08:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239817AbjDZIQg (ORCPT ); Wed, 26 Apr 2023 04:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239909AbjDZIQb (ORCPT ); Wed, 26 Apr 2023 04:16:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B4B10F8 for ; Wed, 26 Apr 2023 01:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682496944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6x+QO0/D6ZnW3l2SgcHzZDuU4TgY6sqC/uSdbpmgmJs=; b=DoU/pH2BI1W1Saemh2W7XER65FO2Xc8n33z56amnSnJ3BiVK9NO0xnr0zEe0/Zje7sRct2 5RCfgFJXaCDIbAR2OBzKs+EodiKNvd2WB+Ok6aD2gU6lkDzUyX3LJ0ShEdENwWaicfjY0Z Kr46tRpWRp5bBzqjQPBcdzdgfZBgBzM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-167-ZCkzw4f8MdaXNRbb65Lbew-1; Wed, 26 Apr 2023 04:15:39 -0400 X-MC-Unique: ZCkzw4f8MdaXNRbb65Lbew-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 49FDB101A551; Wed, 26 Apr 2023 08:15:39 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.39.194.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id BFB2B2027043; Wed, 26 Apr 2023 08:15:37 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: Jakub Kicinski , Eric Dumazet , "David S. Miller" , Russell King , Heiner Kallweit , Andrew Lunn , Arnd Bergmann Subject: [PATCH v2 net-next] net: phy: hide the PHYLIB_LEDS knob Date: Wed, 26 Apr 2023 10:15:31 +0200 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org commit 4bb7aac70b5d ("net: phy: fix circular LEDS_CLASS dependencies") solved a build failure, but introduces a new config knob with a default 'y' value: PHYLIB_LEDS. The latter is against the current new config policy. The exception was raised to allow the user to catch bad configurations without led support. Anyway the current definition of PHYLIB_LEDS does not fit the above goal: if LEDS_CLASS is disabled, the new config will be available only with PHYLIB disabled, too. Hide the mentioned config, to preserve the randconfig testing done so far, while respecting the mentioned policy. Suggested-by: Andrew Lunn Suggested-by: Arnd Bergmann Signed-off-by: Paolo Abeni --- v1 -> v2: - hide the knob instead of drop + IS_REACHABLE() --- drivers/net/phy/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 2f3ddc446cbb..93b8efc79227 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -45,10 +45,8 @@ config LED_TRIGGER_PHY for any speed known to the PHY. config PHYLIB_LEDS - bool "Support probing LEDs from device tree" + def_bool OF depends on LEDS_CLASS=y || LEDS_CLASS=PHYLIB - depends on OF - default y help When LED class support is enabled, phylib can automatically probe LED setting from device tree.