[iproute2,v4,2/5] configure: fix parsing issue on libbpf_dir option

Commit Message

Andrea Claudi Oct. 7, 2021, 1:40 p.m. UTC

configure is stuck in an endless loop if '--libbpf_dir' option is used
without a value:

$ ./configure --libbpf_dir
./configure: line 515: shift: 2: shift count out of range
./configure: line 515: shift: 2: shift count out of range
[...]

Fix it checking that a value is provided with the option.

Fixes: 7ae2585b865a ("configure: convert LIBBPF environment variables to command-line options")
Signed-off-by: Andrea Claudi <[e-mail]>
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff --git a/configure b/configure
index 05f75437..27db3ecb 100755
--- a/configure
+++ b/configure
@@ -486,7 +486,7 @@  usage()
 	cat <<EOF
 Usage: $0 [OPTIONS]
 	--include_dir <dir>	Path to iproute2 include dir
-	--libbpf_dir		Path to libbpf DESTDIR
+	--libbpf_dir <dir>	Path to libbpf DESTDIR
 	--libbpf_force		Enable/disable libbpf by force. Available options:
 				  on: require link against libbpf, quit config if no libbpf support
 				  off: disable libbpf probing
@@ -512,6 +512,7 @@  else
 				shift 2 ;;
 			--libbpf_dir)
 				LIBBPF_DIR="$2"
+				check_value "$LIBBPF_DIR"
 				shift 2 ;;
 			--libbpf_force)
 				if [ "$2" != 'on' ] && [ "$2" != 'off' ]; then