| Message ID | e311f77a9ddb739e3c583201fb99b9945942f68a.1643902526.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | gro: some minor optimization | expand |
From: Paolo Abeni <pabeni@redhat.com> Date: Thu, 3 Feb 2022 16:48:21 +0100 > After commit 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb > carring sock reference") and commit af352460b465 ("net: fix GRO > skb truesize update") the truesize of freed skb is properly updated ^^^^^ One nit here, I'd change this to "truesize of skb with stolen head" or so. It took me a bit of time to get why we should update the truesize of skb already freed (: Right, napi_reuse_skb() makes use of stolen-data skbs. > by the GRO engine, we don't need anymore resetting it at recycle time. > > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- > net/core/gro.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/core/gro.c b/net/core/gro.c > index a11b286d1495..d43d42215bdb 100644 > --- a/net/core/gro.c > +++ b/net/core/gro.c > @@ -634,7 +634,6 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb) > > skb->encapsulation = 0; > skb_shinfo(skb)->gso_type = 0; > - skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); > if (unlikely(skb->slow_gro)) { > skb_orphan(skb); > skb_ext_reset(skb); > -- > 2.34.1 Thanks, Al
diff --git a/net/core/gro.c b/net/core/gro.c index a11b286d1495..d43d42215bdb 100644 --- a/net/core/gro.c +++ b/net/core/gro.c @@ -634,7 +634,6 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb) skb->encapsulation = 0; skb_shinfo(skb)->gso_type = 0; - skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); if (unlikely(skb->slow_gro)) { skb_orphan(skb); skb_ext_reset(skb);
After commit 5e10da5385d2 ("skbuff: allow 'slow_gro' for skb carring sock reference") and commit af352460b465 ("net: fix GRO skb truesize update") the truesize of freed skb is properly updated by the GRO engine, we don't need anymore resetting it at recycle time. Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- net/core/gro.c | 1 - 1 file changed, 1 deletion(-)