| Message ID | e3cdc60663b414d24120cfd2c65b4df500a4037c.1724852597.git.ecree.xilinx@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | sfc: per-queue stats | expand |
On 8/28/2024 6:45 AM, edward.cree@amd.com wrote: > From: Edward Cree <ecree.xilinx@gmail.com> > > This counter is the main difference between the old and new locations > of the rx_packets increment (the other is scatter errors which > produce a WARN_ON). It previously was not reported anywhere; add it > to ethtool -S output to ensure users still have this information. > The description makes sense in context with the whole series but doesn't quite work for me if I think about viewing it without context. Perhaps a little more clarification about the rx_packets behavioral change? > Signed-off-by: Edward Cree <ecree.xilinx@gmail.com> > --- Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > drivers/net/ethernet/sfc/ethtool_common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/sfc/ethtool_common.c b/drivers/net/ethernet/sfc/ethtool_common.c > index a8baeacd83c0..ae32e08540fa 100644 > --- a/drivers/net/ethernet/sfc/ethtool_common.c > +++ b/drivers/net/ethernet/sfc/ethtool_common.c > @@ -83,6 +83,7 @@ static const struct efx_sw_stat_desc efx_sw_stat_desc[] = { > EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_outer_tcp_udp_chksum_err), > EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_eth_crc_err), > EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_frm_trunc), > + EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_overlength), > EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_merge_events), > EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_merge_packets), > EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_xdp_drops), >
On Wed, 28 Aug 2024 14:45:12 +0100 edward.cree@amd.com wrote: > This counter is the main difference between the old and new locations > of the rx_packets increment (the other is scatter errors which > produce a WARN_ON). It previously was not reported anywhere; add it > to ethtool -S output to ensure users still have this information. What is it tho? Not IEEE 802.3 30.3.1.1.25 aFrameTooLongErrors ?
On 29/08/2024 01:47, Jakub Kicinski wrote: > On Wed, 28 Aug 2024 14:45:12 +0100 edward.cree@amd.com wrote: >> This counter is the main difference between the old and new locations >> of the rx_packets increment (the other is scatter errors which >> produce a WARN_ON). It previously was not reported anywhere; add it >> to ethtool -S output to ensure users still have this information. > > What is it tho? Not IEEE 802.3 30.3.1.1.25 aFrameTooLongErrors ? No, it doesn't appear to be. If I'm understanding the code correctly, it counts "RX packets which SG placed in a single RX buffer but whose length (from the RX event) is too big to fit in that RX buffer". Which doesn't sound like a thing that should ever happen (and when it does we netif_err() under ratelimit, see efx_rx_packet__check_len()). I'll put this into the commit message. On 28/08/2024 23:22, Jacob Keller wrote: > The description makes sense in context with the whole series but doesn't > quite work for me if I think about viewing it without context. Perhaps a > little more clarification about the rx_packets behavioral change? Sure, will do.
diff --git a/drivers/net/ethernet/sfc/ethtool_common.c b/drivers/net/ethernet/sfc/ethtool_common.c index a8baeacd83c0..ae32e08540fa 100644 --- a/drivers/net/ethernet/sfc/ethtool_common.c +++ b/drivers/net/ethernet/sfc/ethtool_common.c @@ -83,6 +83,7 @@ static const struct efx_sw_stat_desc efx_sw_stat_desc[] = { EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_outer_tcp_udp_chksum_err), EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_eth_crc_err), EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_frm_trunc), + EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_overlength), EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_merge_events), EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_merge_packets), EFX_ETHTOOL_UINT_CHANNEL_STAT(rx_xdp_drops),