| Message ID | edb1163d-fb78-3af0-2fdd-606c875a535b@sberdevices.ru (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | vsock: updates for SO_RCVLOWAT handling | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 23 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Wed, Aug 03, 2022 at 02:01:57PM +0000, Arseniy Krasnov wrote: >This adds 'vsock_data_ready()' which must be called by transport to kick >sleeping data readers. It checks for SO_RCVLOWAT value before waking >user,thus preventing spurious wake ups.Based on 'tcp_data_ready()' logic. > Since it's an RFC, I suggest you add a space after the punctuation. :-) The patch LGTM: Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> >Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> >--- > include/net/af_vsock.h | 1 + > net/vmw_vsock/af_vsock.c | 10 ++++++++++ > 2 files changed, 11 insertions(+) > >diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h >index eae5874bae35..7b79fc5164cc 100644 >--- a/include/net/af_vsock.h >+++ b/include/net/af_vsock.h >@@ -77,6 +77,7 @@ struct vsock_sock { > s64 vsock_stream_has_data(struct vsock_sock *vsk); > s64 vsock_stream_has_space(struct vsock_sock *vsk); > struct sock *vsock_create_connected(struct sock *parent); >+void vsock_data_ready(struct sock *sk); > > /**** TRANSPORT ****/ > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 3a1426eb8baa..47e80a7cbbdf 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -882,6 +882,16 @@ s64 vsock_stream_has_space(struct vsock_sock *vsk) > } > EXPORT_SYMBOL_GPL(vsock_stream_has_space); > >+void vsock_data_ready(struct sock *sk) >+{ >+ struct vsock_sock *vsk = vsock_sk(sk); >+ >+ if (vsock_stream_has_data(vsk) >= sk->sk_rcvlowat || >+ sock_flag(sk, SOCK_DONE)) >+ sk->sk_data_ready(sk); >+} >+EXPORT_SYMBOL_GPL(vsock_data_ready); >+ > static int vsock_release(struct socket *sock) > { > __vsock_release(sock->sk, 0); >-- >2.25.1
diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h index eae5874bae35..7b79fc5164cc 100644 --- a/include/net/af_vsock.h +++ b/include/net/af_vsock.h @@ -77,6 +77,7 @@ struct vsock_sock { s64 vsock_stream_has_data(struct vsock_sock *vsk); s64 vsock_stream_has_space(struct vsock_sock *vsk); struct sock *vsock_create_connected(struct sock *parent); +void vsock_data_ready(struct sock *sk); /**** TRANSPORT ****/ diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 3a1426eb8baa..47e80a7cbbdf 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -882,6 +882,16 @@ s64 vsock_stream_has_space(struct vsock_sock *vsk) } EXPORT_SYMBOL_GPL(vsock_stream_has_space); +void vsock_data_ready(struct sock *sk) +{ + struct vsock_sock *vsk = vsock_sk(sk); + + if (vsock_stream_has_data(vsk) >= sk->sk_rcvlowat || + sock_flag(sk, SOCK_DONE)) + sk->sk_data_ready(sk); +} +EXPORT_SYMBOL_GPL(vsock_data_ready); + static int vsock_release(struct socket *sock) { __vsock_release(sock->sk, 0);
This adds 'vsock_data_ready()' which must be called by transport to kick sleeping data readers. It checks for SO_RCVLOWAT value before waking user,thus preventing spurious wake ups.Based on 'tcp_data_ready()' logic. Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> --- include/net/af_vsock.h | 1 + net/vmw_vsock/af_vsock.c | 10 ++++++++++ 2 files changed, 11 insertions(+)