| Message ID | f384c3720a340ca5302ee0f97d5e2127e246ce01.1704816744.git.aclaudi@redhat.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | Fix some more typos in docs and comments | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Andrea Claudi <aclaudi@redhat.com> writes: > Fix various typos and spelling errors in some iproute2 comments. > > Signed-off-by: Andrea Claudi <aclaudi@redhat.com> Reviewed-by: Petr Machata <petrm@nvidia.com> > diff --git a/include/bpf_api.h b/include/bpf_api.h > index 5887d3a8..287f96b6 100644 > --- a/include/bpf_api.h > +++ b/include/bpf_api.h > @@ -253,7 +253,7 @@ static int BPF_FUNC(skb_set_tunnel_opt, struct __sk_buff *skb, > # define memmove(d, s, n) __builtin_memmove((d), (s), (n)) > #endif > > -/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug > +/* FIXME: __builtin_memcmp() is not yet fully usable unless llvm bug > * https://llvm.org/bugs/show_bug.cgi?id=26218 gets resolved. Also > * this one would generate a reloc entry (non-map), otherwise. > */ BTW, I wouldn't spell it "useable" myself, but I think it is not incorrect.
On Tue, 9 Jan 2024 17:32:35 +0100 Andrea Claudi <aclaudi@redhat.com> wrote: > diff --git a/include/libiptc/libiptc.h b/include/libiptc/libiptc.h > index 1bfe4e18..89dce2f9 100644 > --- a/include/libiptc/libiptc.h > +++ b/include/libiptc/libiptc.h > @@ -80,7 +80,7 @@ int iptc_append_entry(const xt_chainlabel chain, > const struct ipt_entry *e, > struct xtc_handle *handle); > > -/* Check whether a mathching rule exists */ > +/* Check whether a matching rule exists */ > int iptc_check_entry(const xt_chainlabel chain, > const struct ipt_entry *origfw, > unsigned char *matchmask, This is no longer in current code tree. Please rebase and resubmit
On Thu, Jan 11, 2024 at 11:40:35AM -0800, Stephen Hemminger wrote: > On Tue, 9 Jan 2024 17:32:35 +0100 > Andrea Claudi <aclaudi@redhat.com> wrote: > > > diff --git a/include/libiptc/libiptc.h b/include/libiptc/libiptc.h > > index 1bfe4e18..89dce2f9 100644 > > --- a/include/libiptc/libiptc.h > > +++ b/include/libiptc/libiptc.h > > @@ -80,7 +80,7 @@ int iptc_append_entry(const xt_chainlabel chain, > > const struct ipt_entry *e, > > struct xtc_handle *handle); > > > > -/* Check whether a mathching rule exists */ > > +/* Check whether a matching rule exists */ > > int iptc_check_entry(const xt_chainlabel chain, > > const struct ipt_entry *origfw, > > unsigned char *matchmask, > > This is no longer in current code tree. > Please rebase and resubmit Woops, sorry. Will do.
diff --git a/devlink/devlink.c b/devlink/devlink.c index 3baad355..8c2e3395 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -2326,7 +2326,7 @@ static int dl_argv_dry_parse(struct dl *dl, uint64_t o_required, return err; } -/* List of extented handles with two slashes. */ +/* List of extended handles with two slashes. */ static const uint64_t dl_opt_extended_handle[] = { DL_OPT_HANDLEP, DL_OPT_HANDLE_REGION, diff --git a/include/bpf_api.h b/include/bpf_api.h index 5887d3a8..287f96b6 100644 --- a/include/bpf_api.h +++ b/include/bpf_api.h @@ -253,7 +253,7 @@ static int BPF_FUNC(skb_set_tunnel_opt, struct __sk_buff *skb, # define memmove(d, s, n) __builtin_memmove((d), (s), (n)) #endif -/* FIXME: __builtin_memcmp() is not yet fully useable unless llvm bug +/* FIXME: __builtin_memcmp() is not yet fully usable unless llvm bug * https://llvm.org/bugs/show_bug.cgi?id=26218 gets resolved. Also * this one would generate a reloc entry (non-map), otherwise. */ diff --git a/include/libiptc/libiptc.h b/include/libiptc/libiptc.h index 1bfe4e18..89dce2f9 100644 --- a/include/libiptc/libiptc.h +++ b/include/libiptc/libiptc.h @@ -80,7 +80,7 @@ int iptc_append_entry(const xt_chainlabel chain, const struct ipt_entry *e, struct xtc_handle *handle); -/* Check whether a mathching rule exists */ +/* Check whether a matching rule exists */ int iptc_check_entry(const xt_chainlabel chain, const struct ipt_entry *origfw, unsigned char *matchmask, diff --git a/include/xt-internal.h b/include/xt-internal.h index 89c73e4f..07216140 100644 --- a/include/xt-internal.h +++ b/include/xt-internal.h @@ -6,7 +6,7 @@ # define XT_LIB_DIR "/lib/xtables" #endif -/* protocol family dependent informations */ +/* protocol family dependent information */ struct afinfo { /* protocol family */ int family; diff --git a/lib/json_print.c b/lib/json_print.c index 7b3b6c3f..810d496e 100644 --- a/lib/json_print.c +++ b/lib/json_print.c @@ -217,7 +217,7 @@ int print_color_bool(enum output_type type, /* In JSON mode, acts like print_color_bool. * Otherwise, will print key with prefix of "no" if false. - * The show flag is used to suppres printing in non-JSON mode + * The show flag is used to suppress printing in non-JSON mode */ int print_color_bool_opt(enum output_type type, enum color_attr color, diff --git a/rdma/rdma.h b/rdma/rdma.h index 1f8f8326..df1852db 100644 --- a/rdma/rdma.h +++ b/rdma/rdma.h @@ -40,7 +40,7 @@ struct filter_entry { char *key; char *value; /* - * This field means that we can try to issue .doit calback + * This field means that we can try to issue .doit callback * on value above. This value can be converted to integer * with simple atoi(). Otherwise "is_doit" will be false. */ diff --git a/tc/em_canid.c b/tc/em_canid.c index 6d06b66a..22854752 100644 --- a/tc/em_canid.c +++ b/tc/em_canid.c @@ -26,7 +26,7 @@ #include <inttypes.h> #include "m_ematch.h" -#define EM_CANID_RULES_MAX 400 /* Main reason for this number is Nelink +#define EM_CANID_RULES_MAX 400 /* Main reason for this number is Netlink message size limit equal to Single memory page size. When dump() is invoked, there are even some ematch related headers sent from kernel to userspace together with em_canid configuration -- diff --git a/tc/m_gact.c b/tc/m_gact.c index e294a701..225ffce4 100644 --- a/tc/m_gact.c +++ b/tc/m_gact.c @@ -18,7 +18,7 @@ #include "tc_util.h" #include <linux/tc_act/tc_gact.h> -/* define to turn on probablity stuff */ +/* define to turn on probability stuff */ #ifdef CONFIG_GACT_PROB static const char *prob_n2a(int p) diff --git a/tc/q_htb.c b/tc/q_htb.c index 63b9521b..351ef693 100644 --- a/tc/q_htb.c +++ b/tc/q_htb.c @@ -224,7 +224,8 @@ static int htb_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, opt.ceil.rate = (ceil64 >= (1ULL << 32)) ? ~0U : ceil64; /* compute minimal allowed burst from rate; mtu is added here to make - sute that buffer is larger than mtu and to have some safeguard space */ + sure that buffer is larger than mtu and to have some safeguard space + */ if (!buffer) buffer = rate64 / get_hz() + mtu; if (!cbuffer) diff --git a/tc/q_netem.c b/tc/q_netem.c index 5d5aad80..4ce9ab6e 100644 --- a/tc/q_netem.c +++ b/tc/q_netem.c @@ -117,7 +117,7 @@ static void print_corr(bool present, __u32 value) } /* - * Simplistic file parser for distrbution data. + * Simplistic file parser for distribution data. * Format is: * # comment line(s) * data0 data1 ...
Fix various typos and spelling errors in some iproute2 comments. Signed-off-by: Andrea Claudi <aclaudi@redhat.com> --- devlink/devlink.c | 2 +- include/bpf_api.h | 2 +- include/libiptc/libiptc.h | 2 +- include/xt-internal.h | 2 +- lib/json_print.c | 2 +- rdma/rdma.h | 2 +- tc/em_canid.c | 2 +- tc/m_gact.c | 2 +- tc/q_htb.c | 3 ++- tc/q_netem.c | 2 +- 10 files changed, 11 insertions(+), 10 deletions(-)