@@ -485,7 +485,7 @@ usage()
{
cat <<EOF
Usage: $0 [OPTIONS]
- --include_dir Path to iproute2 include dir
+ --include_dir <dir> Path to iproute2 include dir
--libbpf_dir Path to libbpf DESTDIR
--libbpf_force Enable/disable libbpf by force. Available options:
on: require link against libbpf, quit config if no libbpf support
@@ -495,6 +495,11 @@ EOF
exit $1
}
+check_value()
+{
+ [ -z "$1" ] && usage 1
+}
+
# Compat with the old INCLUDE path setting method.
if [ $# -eq 1 ] && [ "$(echo $1 | cut -c 1)" != '-' ]; then
INCLUDE="$1"
@@ -503,6 +508,7 @@ else
case "$1" in
--include_dir)
INCLUDE=$2
+ check_value "$INCLUDE"
shift 2 ;;
--libbpf_dir)
LIBBPF_DIR="$2"
configure is stuck in an endless loop if '--include_dir' option is used without a value: $ ./configure --include_dir ./configure: line 506: shift: 2: shift count out of range ./configure: line 506: shift: 2: shift count out of range [...] Fix it checking that a value is provided with the option. A dedicated function is used to avoid code duplication, as this check will be needed for further options that may be introduced in the future. Fixes: a9c3d70d902a ("configure: add options ability") Signed-off-by: Andrea Claudi <aclaudi@redhat.com> --- configure | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)