| Message ID | fbc480268644caf24aef68a3b893bdaef71d7306.1626251484.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a99f030b2488b67a49f44e94f852f2ed9933d552 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: switchdev: Simplify 'mlxsw_sp_mc_write_mdb_entry()' | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 5 of 5 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 28 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Wed, Jul 14, 2021 at 10:32:33AM +0200, Christophe JAILLET wrote: > Use 'bitmap_alloc()/bitmap_free()' instead of hand-writing it. > This makes the code less verbose. > > Also, use 'bitmap_alloc()' instead of 'bitmap_zalloc()' because the bitmap > is fully overridden by a 'bitmap_copy()' call just after its allocation. > > While at it, remove an extra and unneeded space. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> For net-next: Reviewed-by: Ido Schimmel <idosch@nvidia.com> Note that net-next is closed [1] so you might need to re-submit, if it does not open soon. Thanks for the patch. [1] http://vger.kernel.org/~davem/net-next.html
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 14 Jul 2021 10:32:33 +0200 you wrote: > Use 'bitmap_alloc()/bitmap_free()' instead of hand-writing it. > This makes the code less verbose. > > Also, use 'bitmap_alloc()' instead of 'bitmap_zalloc()' because the bitmap > is fully overridden by a 'bitmap_copy()' call just after its allocation. > > While at it, remove an extra and unneeded space. > > [...] Here is the summary with links: - net: switchdev: Simplify 'mlxsw_sp_mc_write_mdb_entry()' https://git.kernel.org/netdev/net-next/c/a99f030b2488 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index c5ef9aa64efe..61911fed6aeb 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c @@ -1569,7 +1569,6 @@ mlxsw_sp_mc_write_mdb_entry(struct mlxsw_sp *mlxsw_sp, { long *flood_bitmap; int num_of_ports; - int alloc_size; u16 mid_idx; int err; @@ -1579,18 +1578,17 @@ mlxsw_sp_mc_write_mdb_entry(struct mlxsw_sp *mlxsw_sp, return false; num_of_ports = mlxsw_core_max_ports(mlxsw_sp->core); - alloc_size = sizeof(long) * BITS_TO_LONGS(num_of_ports); - flood_bitmap = kzalloc(alloc_size, GFP_KERNEL); + flood_bitmap = bitmap_alloc(num_of_ports, GFP_KERNEL); if (!flood_bitmap) return false; - bitmap_copy(flood_bitmap, mid->ports_in_mid, num_of_ports); + bitmap_copy(flood_bitmap, mid->ports_in_mid, num_of_ports); mlxsw_sp_mc_get_mrouters_bitmap(flood_bitmap, bridge_device, mlxsw_sp); mid->mid = mid_idx; err = mlxsw_sp_port_smid_full_entry(mlxsw_sp, mid_idx, flood_bitmap, bridge_device->mrouter); - kfree(flood_bitmap); + bitmap_free(flood_bitmap); if (err) return false;
Use 'bitmap_alloc()/bitmap_free()' instead of hand-writing it. This makes the code less verbose. Also, use 'bitmap_alloc()' instead of 'bitmap_zalloc()' because the bitmap is fully overridden by a 'bitmap_copy()' call just after its allocation. While at it, remove an extra and unneeded space. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)