From patchwork Sun Nov 3 16:08:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Braun X-Patchwork-Id: 13860452 X-Patchwork-Delegate: kuba@kernel.org Received: from mail.falix.de (mail.falix.de [37.120.163.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0A7317BEA4 for ; Sun, 3 Nov 2024 16:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.120.163.83 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730650694; cv=none; b=e8J5W7xD2Kx0ciC7q3eslpWOlxIknfA3/uZQZ401I2sdaZRUI6VxzA2Hrtz885VsCtBKLExi4L9+9nq8vxxFq7dEV6T6O2iur+4/02ND6tuCq3sa/BC4OTYySLgrq0OgI/ZTMzMWINj/YGa4ZZBF6NypihU9IutzsUzwmopVpjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730650694; c=relaxed/simple; bh=nQYn6gFGl9woROxHe/Gi2jSjHjIlAquR2tgY5Nvt2ZY=; h=Message-ID:Subject:From:To:Cc:Date:Content-Type:MIME-Version; b=pu8TSTrXKIgdS27fLGNKmQD/WN5sEIFcoDN441RvgX0daBuKCdWe4EdxCCvOh5USAa/Lkr6edgEDLQILdRr5pqOkE0zrIB/GJSNEp+mN4COJckJOKeU4uMHLRMo1aFhN19swCAcroiXvW7wsdN+VtPE6MFUjc36P3ll1Y8W+9e4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=falix.de; spf=pass smtp.mailfrom=falix.de; dkim=pass (2048-bit key) header.d=falix.de header.i=@falix.de header.b=H8lb6lno; arc=none smtp.client-ip=37.120.163.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=falix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=falix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=falix.de header.i=@falix.de header.b="H8lb6lno" Received: from [192.168.221.20] (ppp-82-135-68-177.dynamic.mnet-online.de [82.135.68.177]) by mail.falix.de (Postfix) with ESMTPSA id 238DF6123A; Sun, 03 Nov 2024 17:08:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=falix.de; s=trustedmail; t=1730650103; bh=nQYn6gFGl9woROxHe/Gi2jSjHjIlAquR2tgY5Nvt2ZY=; h=Subject:From:To:Cc:Date; b=H8lb6lnoOby4fu+9cIVktlR7mflljQqvE6w5e2OKSXl6GhlKp/0sj9+2OdMPi9Dvu 9+xc9z4gP8h68EarqEXb0A23UbNJ8FvgiftEPq6HRPHzD/CEnCoTRZcC+mTEWDeS6g 3gvFsiJSA4HYkLbmFhPRENYLIFRXFFuYuC/2KUn/slae8EI9wocFL0sDWZR3H00p+s LoE8naXNlGVgIUY3ywXswzm8mtcYgReDUtKTYbfnB1XIawZI9Rl2+XlFDNKuUJcQwm oJLWNx58uS3JK6ORLkxxVXAfbX700lXWkidMNKoBBpxWIi0t1rqRQHvvIl0i72DSlG Sw5jkWNTsY6zA== Message-ID: Subject: r8169: regression in connection speed with kernels 6.2+ (interrupt coalescing) From: Felix Braun To: Heiner Kallweit , nic_swsd@realtek.com Cc: netdev@vger.kernel.org Date: Sun, 03 Nov 2024 17:08:22 +0100 Organization: Vectrix -- Legal Dept. User-Agent: Evolution 3.54.1 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi there, commit 42f66a44d83715bef810a543dfd66008b883a7a5 to Linus' kernel tree ("r8169: enable GRO software interrupt coalescing per default") introduces a speed regression on my hardware. With that commit applied I get net throughput of 10.5 MB/s, without that commit I get around 100 MB/s on my setup. I've verified that just commenting out the one line in r8169_main.c ``` rtl8169_set_features(dev, dev->features); ``` restores the speed with kernel 6.11.6. Is there perhaps a more elegant way to fix this regression for other people too? Regards Felix This is my lspci -vvxx output: ``` 03:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8211/8411 PCI Express Gigabit Ethernet Controller (rev 15) DeviceName: Onboard - RTK Ethernet Subsystem: ASRock Incorporation Motherboard (one of many) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- hw_features |= NETIF_F_RXALL; dev->hw_features |= NETIF_F_RXFCS; dev->pcpu_stat_type = NETDEV_PCPU_STAT_TSTATS; - netdev_sw_irq_coalesce_default_on(dev); + //netdev_sq_irq_coalesc_default_on(dev); /* configure chip for default features */