diff mbox

[1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits

Message ID 1428705866-26954-1-git-send-email-tariq.x.saeed@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tariq Saeed April 10, 2015, 10:44 p.m. UTC 
Orabug: 19060842

In ocfs2_local_alloc_find_clear_bits(), local int numbits is used
without being initialized in an error path.

Signed-off-by: Tariq Saeed <tariq.x.saeed@oracle.com>
---
 fs/ocfs2/localalloc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Junxiao Bi April 16, 2015, 5:42 a.m. UTC | #1 
Hi Tariq,

This have been fixed by upstream commit
023d4ea358494ccfeb37abfe5b0fd01b45a6051c ("ocfs2: fix possible
uninitialized variable access").

Thanks,
Junxiao.
On 04/11/2015 06:44 AM, Tariq Saeed wrote:
> Orabug: 19060842
> 
> In ocfs2_local_alloc_find_clear_bits(), local int numbits is used
> without being initialized in an error path.
> 
> Signed-off-by: Tariq Saeed <tariq.x.saeed@oracle.com>
> ---
>  fs/ocfs2/localalloc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
> index 0440134..978a6e0 100644
> --- a/fs/ocfs2/localalloc.c
> +++ b/fs/ocfs2/localalloc.c
> @@ -847,6 +847,7 @@ static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb,
>  
>  	if (!alloc->id1.bitmap1.i_total) {
>  		bitoff = -1;
> +		numfound = -1;
>  		goto bail;
>  	}
>  
>
diff mbox

Patch

diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
index 0440134..978a6e0 100644
--- a/fs/ocfs2/localalloc.c
+++ b/fs/ocfs2/localalloc.c
@@ -847,6 +847,7 @@  static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb,
 
 	if (!alloc->id1.bitmap1.i_total) {
 		bitoff = -1;
+		numfound = -1;
 		goto bail;
 	}