diff mbox

ocfs2: Add missing dlm_put() in dlm_begin_reco_handler

Message ID 51A838DB.8030208@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xue jiufei May 31, 2013, 5:44 a.m. UTC 
Function dlm_begin_reco_handler returns without putting dlm 
when dlm recovery state is DLM_RECO_STATE_FINALIZE.

Signed-off-by: joyce <xuejiufei@huawei.com>
---
 fs/ocfs2/dlm/dlmrecovery.c |    1 +
 1 file changed, 1 insertion(+)

-- 1.7.9.7

Comments

jeff.liu May 31, 2013, 7:42 a.m. UTC | #1 
Hi Jiufei,

On 05/31/2013 02:44 PM, Xue jiufei wrote:

> Function dlm_begin_reco_handler returns without putting dlm 
> when dlm recovery state is DLM_RECO_STATE_FINALIZE.
> 
> Signed-off-by: joyce <xuejiufei@huawei.com>

The patch looks good to me, you can consider adding:
Reviewed-by: Jie Liu <jeff.liu@oracle.com>

Thanks,
-Jeff

> ---
>  fs/ocfs2/dlm/dlmrecovery.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index eeac97b..a145cf8 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -2697,6 +2697,7 @@ int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
>  		     dlm->name, br->node_idx, br->dead_node,
>  		     dlm->reco.dead_node, dlm->reco.new_master);
>  		spin_unlock(&dlm->spinlock);
> +		dlm_put(dlm);
>  		return -EAGAIN;
>  	}
>  	spin_unlock(&dlm->spinlock);
> -- 1.7.9.7
> 
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
diff mbox

Patch

diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
index eeac97b..a145cf8 100644
--- a/fs/ocfs2/dlm/dlmrecovery.c
+++ b/fs/ocfs2/dlm/dlmrecovery.c
@@ -2697,6 +2697,7 @@  int dlm_begin_reco_handler(struct o2net_msg *msg, u32 len, void *data,
 		     dlm->name, br->node_idx, br->dead_node,
 		     dlm->reco.dead_node, dlm->reco.new_master);
 		spin_unlock(&dlm->spinlock);
+		dlm_put(dlm);
 		return -EAGAIN;
 	}
 	spin_unlock(&dlm->spinlock);